Bug 25494 - Warnings in advanced editor macros routes
Summary: Warnings in advanced editor macros routes
Status: RESOLVED DUPLICATE of bug 25482
Alias: None
Product: Koha
Classification: Unclassified
Component: REST API (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Tomás Cohen Arazi
QA Contact:
URL:
Keywords:
Depends on: 17268
Blocks:
  Show dependency treegraph
 
Reported: 2020-05-13 21:07 UTC by Tomás Cohen Arazi
Modified: 2020-05-18 09:47 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 25494: Remove warnings in advanced editor macros routes (1.21 KB, patch)
2020-05-13 21:34 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Tomás Cohen Arazi 2020-05-13 21:07:08 UTC
To reproduce:
1. Run:
   $ kshell
  k$ prove t/db_dependent/api/v1/advanced_editor_macros.t
=> FAIL: Two numbers are warned
Comment 1 Tomás Cohen Arazi 2020-05-13 21:34:48 UTC
Created attachment 104855 [details] [review]
Bug 25494: Remove warnings in advanced editor macros routes

There's a couple leftover 'warn's in the controller code.
This patch removes that.

To test:
1. Run:
   $ kshell
  k$ prove t/db_dependent/api/v1/advanced_editor_macros.t
=> FAIL: Two numbers are warned
2. Apply this patch and repeat 1
=> SUCCESS: No more warns
3. Sign off :-D
Comment 2 Bernardo Gonzalez Kriegel 2020-05-14 14:27:47 UTC
(In reply to Tomás Cohen Arazi from comment #1)
> 
> To test:
> 1. Run:
>    $ kshell
>   k$ prove t/db_dependent/api/v1/advanced_editor_macros.t

Can this be tested in a 'legacy' install?
No vagrant/docker but a simple dev install
Test fails for me, but perhaps I need some other setup
Comment 3 Nick Clemens (kidclamp) 2020-05-15 11:33:04 UTC

*** This bug has been marked as a duplicate of bug 25482 ***