Bug 22422 introduced this to the staff search results: [% tnx('{count} item', '{count} items', SEARCH_RESULT.items_count, {count = SEARCH_RESULT.items_count}) | html %][% IF ( SEARCH_RESULT.availablecount ) %], [% SEARCH_RESULT.availablecount | html %] available:[% ELSE %], None available[% END %] But this doesn't appear to get applied, although the strings are translated in the po file. Might also affect other versions, but I couldn't verify.
Ok, it does translate when I reinstall the language in my dev environment. I wonder if this could be related to the packages and the update process? I know translations are automatically updated when you install a new package. Is there a reson why this would not work for the new messages file?
This is probably a WONTFIX because of the old version (we will still investigate a bit more and I will share if we find out something useful) The problem we encountered is that after several updates via packages the strings still appeared untranslated, although po files were in place.
Hm, still seeing issues there on our package based installation. Still investigating and trying to get it to translate. Note the changed dependency, this is related to bug 21789.
We finally found a solution: Koha/I18N.pm looks for the Koha.mo in the wrong path for package based installations. It works fine on git, gitified etc. but not for an installatione done from packages. We solved it for now by creating a symlink.
Needs to be confirmed for other versions than 18.11, but I18N.pm hasn't changed.
Alpha packages are currently building for 20.05.. let's verify if this is still a bug with those.
(In reply to Martin Renvoize from comment #6) > Alpha packages are currently building for 20.05.. let's verify if this is > still a bug with those. Thank you!
sub _base_directory { return C4::Context->config('intranetdir') . '/misc/translator/po'; } but debian/templates/koha-conf-site.xml.in: <intranetdir>/usr/share/koha/intranet/cgi-bin</intranetdir> And POs are in /usr/share/koha/misc/translator/po
Thx Joubu, that's exactly the problem we've seen. Now hoping it can be fixed.
Created attachment 105270 [details] [review] Bug 25517: Look in all possible places for MO files On a 'dev' install, MO files will be installed in <intranetdir>/misc/translator/po On 'standard' and 'single' installs, they will be installed in <intranetdir>/../../misc/translator/po This patch makes Koha::I18N try to use the "dev" directory first, and fallback to the "standard" directory. If none of these directories exist, it dies.
This might be more of a quick fix as noted in the FIXME. But given we are a bit short of time to the release we might want to consider it. I am doing a regression test as I can't test on a package installation myself, so take the sign-off with that grain of salt!
Created attachment 105276 [details] [review] Bug 25517: Look in all possible places for MO files On a 'dev' install, MO files will be installed in <intranetdir>/misc/translator/po On 'standard' and 'single' installs, they will be installed in <intranetdir>/../../misc/translator/po This patch makes Koha::I18N try to use the "dev" directory first, and fallback to the "standard" directory. If none of these directories exist, it dies. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Passing QA.. local testing proved fruitful. Thanks for the quick fix.. lets see if there's a nicer way as part of the next cycle.
Nice work everyone! Pushed to master for 20.05
backported to 19.11.x for 19.11.07
Backported to 19.05.x branch for 19.05.12