Bug 25519 - [18.11] TinyMCE editor pop ups broken
Summary: [18.11] TinyMCE editor pop ups broken
Status: CLOSED WONTFIX
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: 18.11
Hardware: All All
: P5 - low normal (vote)
Assignee: Katrin Fischer
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-05-15 18:46 UTC by Katrin Fischer
Modified: 2021-06-14 21:29 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 25519: [18.11] Fix missing dialog.css in TinyMCE editor (3.08 KB, patch)
2020-05-15 18:52 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 25519: [18.11] Fix missing dialog.css in TinyMCE editor (3.13 KB, patch)
2020-06-11 11:07 UTC, David Nind
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2020-05-15 18:46:53 UTC
The pop-ups for adding links, files or anchors from the TinyMCE editor are broken.
Comment 1 Katrin Fischer 2020-05-15 18:52:28 UTC
Created attachment 104965 [details] [review]
Bug 25519: [18.11] Fix missing dialog.css in TinyMCE editor

When using the TinyMCE editor in 18.11 all functionalities
used from popups (anchors, images, links) are broken because
dialog.css is missing.

To test: First verify the problem on the following pages:

1) Tools > News
- Add or edit a news entry

2) Administration > Libraries
- Add or edit OPAC info for one of the libraries

3) Administration > System preferences
- Activate UseWYSIWYGinSystemPreferences
- Try the editor on any of the HTML preferences like OpacMainUserBlock

Apply the patch and repeat. The styling should be back, which especially
makes adding links usable again.
Comment 2 Katrin Fischer 2020-05-15 18:54:02 UTC
Maybe too late as 18.11 is end of life... but it might still be useful for sonmeone.
Comment 3 David Nind 2020-06-11 11:07:08 UTC
Created attachment 105732 [details] [review]
Bug 25519: [18.11] Fix missing dialog.css in TinyMCE editor

When using the TinyMCE editor in 18.11 all functionalities
used from popups (anchors, images, links) are broken because
dialog.css is missing.

To test: First verify the problem on the following pages:

1) Tools > News
- Add or edit a news entry

2) Administration > Libraries
- Add or edit OPAC info for one of the libraries

3) Administration > System preferences
- Activate UseWYSIWYGinSystemPreferences
- Try the editor on any of the HTML preferences like OpacMainUserBlock

Apply the patch and repeat. The styling should be back, which especially
makes adding links usable again.

Signed-off-by: David Nind <david@davidnind.com>
Comment 4 Katrin Fischer 2020-06-11 11:35:21 UTC
David, thx for signing off - I kind of forgot about this one :(

With the release of 20.05 this turned into a WONTFIX as 18.11 will see on more releases. It might still be helpful to someone investigating the same issue. I am closing the bug.