Created attachment 105640 [details] [review] Bug 25693: Set correct permissions on logdir after an upgrade Since bug 25172 we are failing loudly if the permissions are not correct and that the logger cannot init successfully. We must set the correct permission on upgrading. koha-create deals with new installs
Upping severity as it impacts stable release upgrades
Extracted the code snippet and tested it on its own. Works as expected.
Created attachment 105642 [details] [review] Bug 25693: Set correct permissions on logdir after an upgrade Since bug 25172 we are failing loudly if the permissions are not correct and that the logger cannot init successfully. We must set the correct permission on upgrading. koha-create deals with new installs Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 105644 [details] [review] Bug 25693: Set correct permissions on logdir after an upgrade Since bug 25172 we are failing loudly if the permissions are not correct and that the logger cannot init successfully. We must set the correct permission on upgrading. koha-create deals with new installs Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Built a package and trialled an upgrade.. worked as expected for me.. Passing QA
Pushed to master for 20.11, thanks to everybody involved!
backported to 20.05.x for 20.05.01
backported to 19.11.x for 19.11.07
Won't backport to 19.05.x, log4perl wasn't in koha-common.postinst back then.