Turns out the database update for this change causes unexpected changes to the "Koha to MARC mapping" (via the MARC frameworks)
Created attachment 105680 [details] [review] Bug 25707: (bug 11529 follow-up) Do not update marc mappings, print old mappings to upgrade log This patch removes the update of marc frameworks from the updatedatabase script and warns the "MARC to Keyword" (fieldmappings ) to the upgrade log so they can be replaced manually Signed-off-by: David Cook <dcook@prosentient.com.au>
I wouldn't say it causes data loss because the data is still in the MARC record but it causes... incorrect MARC to DB mappings?
(In reply to David Cook from comment #2) > I wouldn't say it causes data loss because the data is still in the MARC > record but it causes... incorrect MARC to DB mappings? It overwrites existing mappings and they are not preserved, so the only way to recover is from backup.
@Kyle I don't understand why are you taking out the WHERE condition. And the warning message could be more clear about why they are wrong, otherwise it just says 'go remap' to what?.
The where condition was there to not warn the mappings that we attempted to update. We are no longer making this attempt so we want to list the whole table Something like: The keyword to marc mapping feature is no longer supported. Above find the mappings that had been defined in your system. You will need to remap any desired MARC fields to the Koha field you desire in the Koha to MARC mappings page under Administration
(In reply to Nick Clemens from comment #5) > The where condition was there to not warn the mappings that we attempted to > update. We are no longer making this attempt so we want to list the whole > table I get it. > Something like: > The keyword to marc mapping feature is no longer supported. Above find the > mappings that had been defined in your system. You will need to remap any > desired MARC fields to the Koha field you desire in the Koha to MARC > mappings page under Administration That reads better :-D
Created attachment 105771 [details] [review] Bug 25707: (bug 11529 follow-up) Do not update marc mappings, print old mappings to upgrade log This patch removes the update of marc frameworks from the updatedatabase script and warns the "MARC to Keyword" (fieldmappings ) to the upgrade log so they can be replaced manually Signed-off-by: David Cook <dcook@prosentient.com.au> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 105772 [details] [review] Bug 25707: (QA follow-up) Clearer message about what's going on Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(In reply to Nick Clemens from comment #3) > (In reply to David Cook from comment #2) > > I wouldn't say it causes data loss because the data is still in the MARC > > record but it causes... incorrect MARC to DB mappings? > > It overwrites existing mappings and they are not preserved, so the only way > to recover is from backup. Ohh I see what you mean. I thought you meant MARC data would be lost, but you're referring to the mapping data. That makes sense. Honestly, I didn't recover from the backups. I just reset the mappings to reasonable defaults.
(In reply to David Cook from comment #9) > (In reply to Nick Clemens from comment #3) > > (In reply to David Cook from comment #2) > > > I wouldn't say it causes data loss because the data is still in the MARC > > > record but it causes... incorrect MARC to DB mappings? > > > > It overwrites existing mappings and they are not preserved, so the only way > > to recover is from backup. > > Ohh I see what you mean. I thought you meant MARC data would be lost, but > you're referring to the mapping data. That makes sense. > > Honestly, I didn't recover from the backups. I just reset the mappings to > reasonable defaults. Since the mappings can be re-created, I wasn't thinking of it as data loss, since the valuable data (the MARC data) is still preserved.
Pushed to master for 20.11, thanks to everybody involved!
backported to 20.05.x for 20.05.01
backported to 19.11.x for 19.11.07
Missing dependencies for 19.05.x, no backport. 19.05.x shouldn't be affected.