Bug 25748 - When trying to transfer an item with a hold on it options are confusing
Summary: When trying to transfer an item with a hold on it options are confusing
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: Hold requests (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-06-14 12:32 UTC by Katrin Fischer
Modified: 2020-06-15 16:09 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Who signed the patch off:
Text to go in the release notes:
Version(s) released in:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2020-06-14 12:32:44 UTC
I have to confess, I had never seen these messages before, I just ran into it trying to see if could reproduce the conditions from bug 25726.

Try: 
- Place a record level hold on a record with at least one item in your current library
- Copy the item barcode of your current library
- Change your library
- Try to manually transfer the item to the homebranch library

This is what you should see:

Set reserve to waiting and transfer book to : 	Waiting
Cancel reservation and then attempt transfer: 	Cancel
Ignore and return to transfers: 	Ignore

1) extra space after to and library name is missing. 
Also: We are not at the library and still the hold is set to "Waiting" instead of "T". That means the patron will get a notice, but the item is not there yet. The first option seems highly problematic. It can't be in a transport box in a van and in the library at the same time?

2) reservation and reserve should all be 'hold' instead

From a users perspective, I am not sure what option I should select. Actually I think 'ignore' and returning the item normally would be best? But it's the last option and ignore doesn't appear inviting.

Cancel might be accidentally clicked - I think the button should at least be "Cancel hold" to stand out more.

Ignore could be "Don't transfer"

Waiting could be "Set waiting and transfer" - although that option maybe should be removed or replaced.

Adding Andrew and Kyle as hold experts...
Comment 1 Owen Leonard 2020-06-14 15:19:12 UTC
I'm working on a lot of the interface issues in Bug 25682.
Comment 2 Owen Leonard 2020-06-15 15:52:40 UTC
Some transfer debugging:

 - Item on hold to be sent to Branch A
 - Submit transfer from Branch A
 - Select as transfer destination: Branch B
 - Submit barcode for item on hold
   - When confirmation is shown:
     - Select "Set reserve to waiting and transfer book to : [Waiting]"

Result:

 - Detail page for the title shows that the item is "Waiting at Branch A."
 - Detail page ALSO says the item is currently at its home library.
Comment 3 Owen Leonard 2020-06-15 15:59:31 UTC
Another test:

 - Item on hold to be sent to Branch A
 - Submit transfer from Branch A
 - Select as transfer destination: Branch B
 - Submit barcode for item on hold
   - When confirmation is shown:
     - Select "Cancel reservation and then attempt transfer: [Cancel]"

Result:

 - Detail page for the title show that the item is "In transit"
   from the item's *home library* (not the library it was
   transferred from) to the transfer destination (Branch B).
 - Hold is cancelled.
Comment 4 Owen Leonard 2020-06-15 16:05:48 UTC
Another test:

 - Item on hold to be sent to Branch A
 - Submit transfer from Branch A
 - Select as transfer destination: Branch B
 - Submit barcode for item on hold
   - When confirmation is shown:
     - Select "Ignore and return to transfers: [Ignore]"

Result:

 - Detail page for the title show that the item is "In transit"
   from the item's *home library* (not the library it was
   transferred from) to the transfer destination (Branch B).
 - Hold is not cancelled.