Created attachment 105885 [details] empty HTML table row As per the attached screenshot, in the Staff Client the OPAC "Appearance" preferences table has an extra, empty HTML table row at the end.
Created attachment 105886 [details] [review] Bug 25756: remove erroneous hyphen In the Staff Client, the OPAC "Appearance" preferences table has an extra, empty HTML table row at the end. Test plan: 0) Observe the empty HTML table row at the end of the table that lists OPAC "Appearance" system preferences. 1) Apply this patch. 2) Observe that the empty table row is now gone.
Created attachment 105971 [details] [review] Bug 25756: remove erroneous hyphen In the Staff Client, the OPAC "Appearance" preferences table has an extra, empty HTML table row at the end. Test plan: 0) Observe the empty HTML table row at the end of the table that lists OPAC "Appearance" system preferences. 1) Apply this patch. 2) Observe that the empty table row is now gone. Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 106076 [details] [review] Bug 25756: remove erroneous hyphen In the Staff Client, the OPAC "Appearance" preferences table has an extra, empty HTML table row at the end. Test plan: 0) Observe the empty HTML table row at the end of the table that lists OPAC "Appearance" system preferences. 1) Apply this patch. 2) Observe that the empty table row is now gone. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Good catch, passing QA
Pushed to master for 20.11, thanks to everybody involved!
backported to 20.05.x for 20.05.02
backported to 19.11.x for 19.11.08
Backported to 19.05.x branch for 19.05.14