Sometimes after an order has come in there are donations or changes to funds and the library may wish to change the fund that the order is allocated from. This bug will allow updating the order fund from the invoice page.
Created attachment 105892 [details] [review] Bug 25763: Allow updating of order fund from invoice To test: 1 - Receive some orders via acquisitions 2 - View the invoice with these orders 3 - Click 'Modify fund' on the received orders list 4 - Confirm you can change the fund 5 - Set some authorised value categories for funds 6 - Reload the invoice 7 - Confirm the categories dropdowns change when different funds selected 8 - Confirm updating the statistic fields saves correctly 9 - Add an inactive budget with some funds 10 - Test the 'show inactive' button on shipment fund, adjustments, and modifying order fund
Hi Nick ! Sorry about that, i'd be happy to test it if you can fix that one ! 105892 - Bug 25763: Allow updating of order fund from invoice Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 25763: Allow updating of order fund from invoice Using index info to reconstruct a base tree... M acqui/invoice.pl M koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoice.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoice.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoice.tt Auto-merging acqui/invoice.pl Failed to merge in the changes. Patch failed at 0001 Bug 25763: Allow updating of order fund from invoice
Created attachment 114678 [details] [review] Bug 25763: Allow updating of order fund from invoice To test: 1 - Receive some orders via acquisitions 2 - View the invoice with these orders 3 - Click 'Modify fund' on the received orders list 4 - Confirm you can change the fund 5 - Set some authorised value categories for funds 6 - Reload the invoice 7 - Confirm the categories dropdowns change when different funds selected 8 - Confirm updating the statistic fields saves correctly 9 - Add an inactive budget with some funds 10 - Test the 'show inactive' button on shipment fund, adjustments, and modifying order fund
Created attachment 115368 [details] [review] Bug 25763: Allow updating of order fund from invoice To test: 1 - Receive some orders via acquisitions 2 - View the invoice with these orders 3 - Click 'Modify fund' on the received orders list 4 - Confirm you can change the fund 5 - Set some authorised value categories for funds 6 - Reload the invoice 7 - Confirm the categories dropdowns change when different funds selected 8 - Confirm updating the statistic fields saves correctly 9 - Add an inactive budget with some funds 10 - Test the 'show inactive' button on shipment fund, adjustments, and modifying order fund Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov>
Hi Nick, I like the idea of this! I believe the "No fund" option should be removed here. An order will always have a fund as it's mandatory and if you try to unset it (which should not be possible) you receive an error on saving. Statistic 1 and 2 should also end with a colon as form labels. The GUI looks a little bit "rough", but it's subtle, like some missing padding or maybe because the form fields are not aligned nicely with the labels? Could be something for a later patch.
Created attachment 140865 [details] [review] Bug 25763: Allow updating of order fund from invoice To test: 1 - Receive some orders via acquisitions 2 - View the invoice with these orders 3 - Click 'Modify fund' on the received orders list 4 - Confirm you can change the fund 5 - Set some authorised value categories for funds 6 - Reload the invoice 7 - Confirm the categories dropdowns change when different funds selected 8 - Confirm updating the statistic fields saves correctly 9 - Add an inactive budget with some funds 10 - Test the 'show inactive' button on shipment fund, adjustments, and modifying order fund Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov>
Created attachment 140866 [details] [review] Bug 25763: (follow-up) Fix display and remove 'No fund' This patch adds a fieldset around the inputs to style them as other places in Koha
(In reply to Katrin Fischer from comment #5) > Hi Nick, I like the idea of this! > > I believe the "No fund" option should be removed here. An order will always > have a fund as it's mandatory and if you try to unset it (which should not > be possible) you receive an error on saving. > > Statistic 1 and 2 should also end with a colon as form labels. > > The GUI looks a little bit "rough", but it's subtle, like some missing > padding or maybe because the form fields are not aligned nicely with the > labels? Could be something for a later patch. I did not remember writing this... is this that getting old thing?
Created attachment 141546 [details] [review] Bug 25763: Allow updating of order fund from invoice To test: 1 - Receive some orders via acquisitions 2 - View the invoice with these orders 3 - Click 'Modify fund' on the received orders list 4 - Confirm you can change the fund 5 - Set some authorised value categories for funds 6 - Reload the invoice 7 - Confirm the categories dropdowns change when different funds selected 8 - Confirm updating the statistic fields saves correctly 9 - Add an inactive budget with some funds 10 - Test the 'show inactive' button on shipment fund, adjustments, and modifying order fund Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 141547 [details] [review] Bug 25763: (follow-up) Fix display and remove 'No fund' This patch adds a fieldset around the inputs to style them as other places in Koha Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
I like this functionality, but I'd like it better if the changes were logged. I filed bug 31721 to make a case for logging changes made to orders via the API.
Pushed to master for 22.11. Nice work everyone, thanks!