Bug 25763 - Allow update of order fund after receipt
Summary: Allow update of order fund after receipt
Status: Signed Off
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Nick Clemens
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-06-15 21:04 UTC by Nick Clemens
Modified: 2022-09-23 12:15 UTC (History)
5 users (show)

See Also:
Change sponsored?: Sponsored
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 25763: Allow updating of order fund from invoice (14.43 KB, patch)
2020-06-15 21:15 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 25763: Allow updating of order fund from invoice (14.69 KB, patch)
2020-12-23 15:25 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 25763: Allow updating of order fund from invoice (14.75 KB, patch)
2021-01-19 22:25 UTC, PTFS Europe Sandboxes
Details | Diff | Splinter Review
Bug 25763: Allow updating of order fund from invoice (15.98 KB, patch)
2022-09-22 20:12 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 25763: (follow-up) Fix display and remove 'No fund' (2.63 KB, patch)
2022-09-22 20:12 UTC, Nick Clemens
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Clemens 2020-06-15 21:04:44 UTC
Sometimes after an order has come in there are donations or changes to funds and the library may wish to change the fund that the order is allocated from.

This bug will allow updating the order fund from the invoice page.
Comment 1 Nick Clemens 2020-06-15 21:15:03 UTC
Created attachment 105892 [details] [review]
Bug 25763: Allow updating of order fund from invoice

To test:
 1 - Receive some orders via acquisitions
 2 - View the invoice with these orders
 3 - Click 'Modify fund' on the received orders list
 4 - Confirm you can change the fund
 5 - Set some authorised value categories for funds
 6 - Reload the invoice
 7 - Confirm the categories dropdowns change when different funds selected
 8 - Confirm updating the statistic fields saves correctly
 9 - Add an inactive budget with some funds
10 - Test the 'show inactive' button on shipment fund, adjustments, and modifying order fund
Comment 2 Séverine Queune 2020-10-20 13:23:26 UTC
Hi Nick !
Sorry about that, i'd be happy to test it if you can fix that one !

105892 - Bug 25763: Allow updating of order fund from invoice

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 25763: Allow updating of order fund from invoice
Using index info to reconstruct a base tree...
M       acqui/invoice.pl
M       koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoice.tt
Falling back to patching base and 3-way merge...
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoice.tt
CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoice.tt
Auto-merging acqui/invoice.pl
Failed to merge in the changes.
Patch failed at 0001 Bug 25763: Allow updating of order fund from invoice
Comment 3 Nick Clemens 2020-12-23 15:25:11 UTC
Created attachment 114678 [details] [review]
Bug 25763: Allow updating of order fund from invoice

To test:
 1 - Receive some orders via acquisitions
 2 - View the invoice with these orders
 3 - Click 'Modify fund' on the received orders list
 4 - Confirm you can change the fund
 5 - Set some authorised value categories for funds
 6 - Reload the invoice
 7 - Confirm the categories dropdowns change when different funds selected
 8 - Confirm updating the statistic fields saves correctly
 9 - Add an inactive budget with some funds
10 - Test the 'show inactive' button on shipment fund, adjustments, and modifying order fund
Comment 4 PTFS Europe Sandboxes 2021-01-19 22:25:58 UTC
Created attachment 115368 [details] [review]
Bug 25763: Allow updating of order fund from invoice

To test:
 1 - Receive some orders via acquisitions
 2 - View the invoice with these orders
 3 - Click 'Modify fund' on the received orders list
 4 - Confirm you can change the fund
 5 - Set some authorised value categories for funds
 6 - Reload the invoice
 7 - Confirm the categories dropdowns change when different funds selected
 8 - Confirm updating the statistic fields saves correctly
 9 - Add an inactive budget with some funds
10 - Test the 'show inactive' button on shipment fund, adjustments, and modifying order fund

Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov>
Comment 5 Katrin Fischer 2021-02-14 15:44:54 UTC
Hi Nick, I like the idea of this!

I believe the "No fund" option should be removed here. An order will always have a fund as it's mandatory and if you try to unset it (which should not be possible) you receive an error on saving.

Statistic 1 and 2 should also end with a colon as form labels.

The GUI looks a little bit "rough", but it's subtle, like some missing padding or maybe because the form fields are not aligned nicely with the labels? Could be something for a later patch.
Comment 6 Nick Clemens 2022-09-22 20:12:42 UTC
Created attachment 140865 [details] [review]
Bug 25763: Allow updating of order fund from invoice

To test:
 1 - Receive some orders via acquisitions
 2 - View the invoice with these orders
 3 - Click 'Modify fund' on the received orders list
 4 - Confirm you can change the fund
 5 - Set some authorised value categories for funds
 6 - Reload the invoice
 7 - Confirm the categories dropdowns change when different funds selected
 8 - Confirm updating the statistic fields saves correctly
 9 - Add an inactive budget with some funds
10 - Test the 'show inactive' button on shipment fund, adjustments, and modifying order fund

Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov>
Comment 7 Nick Clemens 2022-09-22 20:12:46 UTC
Created attachment 140866 [details] [review]
Bug 25763: (follow-up) Fix display and remove 'No fund'

This patch adds a fieldset around the inputs to style them as other places in Koha