Bug 25768 - Add details to permission Remaining system parameters permissions (parameters_remaining_permissions)
Summary: Add details to permission Remaining system parameters permissions (parameter...
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: Patrons (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-06-16 11:57 UTC by Kelly McElligott
Modified: 2020-10-18 15:11 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Text to go in the release notes:
Version(s) released in:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Kelly McElligott 2020-06-16 11:57:30 UTC
There are no details on what this specific permission entails in the Admin area of Staff permissions.  It looks like these remaining permissions are all Acquisition based, and it would be more beneficial to the library to know that when setting/adjusting permissions.

If this permission is set, the patron will have access to the Acquisitions Parameters, currency, budgets, funds, EDI accounts, and EAN. However, if the patron doesn't already have acquisition permission, choosing this Admin permission doesn't appear to give any more access - just the Admin button itself. 

Could the permission be more specific in detail Remaining system parameters permissions (parameters_remaining_permissions) and also indicate it needs Acq permissions?
Comment 1 Katrin Fischer 2020-10-18 15:09:13 UTC
Hi Kelly,

when you create a patron only with "catalogue" and "remaining permissions" the administration page will appear empty - actually all bits there are covered by separate permissions. I believe maybe when testing your staff user also had acq permissions set.

At the moment there are only 3 checks for the permission:

admin/credit_types.pl:        flagsrequired   => { parameters => 'parameters_remaining_permissions' },
admin/debit_types.pl:        flagsrequired   => { parameters => 'parameters_remaining_permissions' },
admin/overdrive.pl:        flagsrequired   => { parameters => 'parameters_remaining_permissions' },

I believe the first 2 are false and should be changed to parameters_manage_accounts as this is already checked on the admin home page. I'll file for them separately.

So that only leaves Overdrive that is really controlled by the permission. But I am not sure how to activate that - can you help there? We seem to have an admin page just for it, but it is not linked from anywhere:

/cgi-bin/koha/admin/overdrive.pl