Bug 25806 - Move Koha::CirculationRules special cases into overloaded Koha::CirculationRule method
Summary: Move Koha::CirculationRules special cases into overloaded Koha::CirculationRu...
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-06-18 15:09 UTC by Martin Renvoize (ashimema)
Modified: 2023-12-10 09:17 UTC (History)
0 users

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Renvoize (ashimema) 2020-06-18 15:09:06 UTC 
The current special case accessors are inconsistently named and inconsistently implemented in the Koha::CirculationRules module.. it would be better to allow access to rules via get_effective_rule and get_effective_rules consistently and remove the special accessors by replacing the special case handling, mostly adding defaults, with overloaded an overloaded value field accessor in the Koha::CirculationRule result object.
Comment 2 Katrin Fischer 2023-12-10 09:17:49 UTC 
Is this still valid?