Currently, when setting up permission for staff, the report for Overdue reports portion of the Circulation module, is only partially included in staff permission. There is a permission that allows staff to run the Overdue report )Execute overdue items report (overdues_report)) - but this does prohibit the Overdue report from displaying on circulation page, but the Overdue with Fines does display. It would more helpful, if this permission included both reports or add another permission to allow libraries to include/exclude this other report.
I'm ruling this a bug rather than an enhancement. Either the existing permission should be renamed to reflect its limited scope, or its scope should be expanded to include the Overdues With Fines report.
Created attachment 159363 [details] [review] Bug 25835: Include overdues with fines in overdues_report permission To test: 1 - have a user with circulate_remaining_permissions but not overdues_report 2 - confirm user can see and run Overdues with Fines 3 - apply patch 4 - confirm user can no longer see links to Overdues with Fines or load the page directly by entering the url 5 - confirm a user with overdues_report or greate permission can see and use the tool
Created attachment 159364 [details] [review] Bug 25835: Include overdues with fines in overdues_report permission To test: 1 - have a user with circulate_remaining_permissions but not overdues_report 2 - confirm user can see and run Overdues with Fines 3 - apply patch 4 - confirm user can no longer see links to Overdues with Fines or load the page directly by entering the url 5 - confirm a user with overdues_report or greate permission can see and use the tool Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 160592 [details] [review] Bug 25835: Include overdues with fines in overdues_report permission To test: 1 - have a user with circulate_remaining_permissions but not overdues_report 2 - confirm user can see and run Overdues with Fines 3 - apply patch 4 - confirm user can no longer see links to Overdues with Fines or load the page directly by entering the url 5 - confirm a user with overdues_report or greate permission can see and use the tool Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Pushed for 24.05! Well done everyone, thank you!
Pushed to 23.11.x for 23.11.02
Backported to 23.05.x for upcoming 23.05.08