Bug 25912 - Any lost value triggers refund message on check in, even if it doesn't apply
Summary: Any lost value triggers refund message on check in, even if it doesn't apply
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: 19.11
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-07-01 22:12 UTC by Christopher Brannon
Modified: 2023-12-09 16:15 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Christopher Brannon 2020-07-01 22:12:07 UTC
Apparently the "A refund has been applied to the borrowing patron's account." message shows up for any item that has a lost status.  But not all lost statuses, like "Missing" or "Claims returned" have a fee that needs to be refunded.

Would like to see LOST values with a negative value not apply this message.

OR

Modify RefundLostOnReturnControl to have another setting to indicate which LOST values to apply a refund/show a message for.
Comment 1 Katrin Fischer 2020-07-01 22:16:26 UTC
I think I filed a similar bug to this sometime. The negative/positive would be hard to implement nicely at this point in time without giving some grief to libraries (lots of changes required in a lot of libraries as the default 'missing' is positive).  So I'd vote for the second option.

Could it also be an alternative to not show the message if the item is no longer checked out?
Comment 2 Katrin Fischer 2020-07-01 22:19:25 UTC
Duplicate to bug 11723?
Comment 3 Andrew Fuerste-Henry 2020-07-02 12:26:22 UTC
It seems like we've got two separate things here. First, there's a bug with the existing functionality, that it's not being accurate about whether or not a fee will be refunded. Looks like that's covered in bug 11723.

Second, there's an enhancement to introduce functionality for some lost values to not generate refunds. Let's maybe made this bug focus on that?

Maybe we add a corollary syspref to RefundLostOnReturnControl that takes a list of exceptions? Or just change RefundLostOnReturnControl so instead of a yes/no switch one enters a list of lost status for which one wants to refund? And leave blank if no refund is desired?
Comment 4 Christopher Brannon 2020-07-02 14:19:03 UTC
I down with the second idea.  Just have a list in place of the control.  If there is nothing there, nothing happens.  We only list what we want action on.
Comment 5 Christopher Brannon 2020-07-02 14:19:52 UTC
Wish I could edit my comments in bugzilla sometimes.  :/
Comment 6 Katrin Fischer 2023-12-09 16:15:50 UTC
It looks like the bug description should be updated?