This bug tracks the task of adding the liblocale-codes-perl package, to fix ubuntu-stable (focal) looks like perl-5.30 on debian needs liblocale-codes-perl root@buster:kohadevbox$ pmvers Locale::Language Locale::Language will be removed from the Perl core distribution in the next major release. Please install the separate liblocale-codes-perl package. It is being used at (eval 1), line 1. Locale::Codes will be removed from the Perl core distribution in the next major release. Please install the separate liblocale-codes-perl package. It is being used at /usr/share/perl/5.28/Locale/Language.pm, line 22. 3.56
Created attachment 106497 [details] [review] Bug 25920: Add liblocale-codes-perl package to fix ubuntu-stable (focal) to test on ubuntu-20... 1/ install koha-common pkg $ sudo apt install koha-common 2/ confirm liblocale-codes-perl pkg is not installed :( $ apt-cache policy liblocale-codes-perl | grep Installed Installed: (none) 3/ apply patch 4/ build and install new koha-common pkg 5/ confirm liblocale-codes-perl pkg is now installed :) $ apt-cache policy liblocale-codes-perl | grep Installed Installed: 3.62-1
> 5/ confirm liblocale-codes-perl pkg is now installed :) > $ apt-cache policy liblocale-codes-perl | grep Installed > Installed: 3.62-1 until this patch is pushed, you can manually fix this problem with the following command $ sudo apt install liblocale-codes-perl
Created attachment 106672 [details] pic of error
(In reply to Mason James from comment #0) > This bug tracks the task of adding the liblocale-codes-perl package, to fix > ubuntu-stable (focal) > > looks like perl-5.30 on debian needs liblocale-codes-perl hmm, problem exists on debian 11 too
(In reply to Mason James from comment #5) > (In reply to Mason James from comment #0) > > This bug tracks the task of adding the liblocale-codes-perl package, to fix > > ubuntu-stable (focal) > > > > looks like perl-5.30 on debian needs liblocale-codes-perl > > > hmm, problem exists on debian 11 too this seems to stop installation at the 'web installer' stage
Created attachment 107171 [details] [review] Bug 25920: Add liblocale-codes-perl package to fix ubuntu-stable (focal) to test on ubuntu-20... 1/ install koha-common pkg $ sudo apt install koha-common 2/ confirm liblocale-codes-perl pkg is not installed :( $ apt-cache policy liblocale-codes-perl | grep Installed Installed: (none) 3/ apply patch 4/ build and install new koha-common pkg 5/ confirm liblocale-codes-perl pkg is now installed :) $ apt-cache policy liblocale-codes-perl | grep Installed Installed: 3.62-1 Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Works as expected from the test plan. Signing off
Created attachment 107480 [details] [review] Bug 25920: Add liblocale-codes-perl package to fix ubuntu-stable (focal) to test on ubuntu-20... 1/ install koha-common pkg $ sudo apt install koha-common 2/ confirm liblocale-codes-perl pkg is not installed :( $ apt-cache policy liblocale-codes-perl | grep Installed Installed: (none) 3/ apply patch 4/ build and install new koha-common pkg 5/ confirm liblocale-codes-perl pkg is now installed :) $ apt-cache policy liblocale-codes-perl | grep Installed Installed: 3.62-1 Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi>
Pushed to master for 20.11, thanks to everybody involved!
backported to 20.05.x for 20.05.03
backported to 19.11.x for 19.11.09
Tried to backport to 19.05.x, got this conflict: <<<<<<< HEAD ||||||| parent of f19e6015b0... Bug 25920: Add liblocale-codes-perl package to fix ubuntu-stable (focal) 'CPAN::Meta' => 'libcpan-meta-perl (>= 2.150010) | perl-modules-5.28 | perl-modules-5.30 | perl-modules (>= 5.20.2)' ======= 'CPAN::Meta' => 'libcpan-meta-perl (>= 2.150010) | perl-modules-5.28 | perl-modules-5.30 | perl-modules (>= 5.20.2)', 'Locale::Language' => 'liblocale-codes-perl' >>>>>>> f19e6015b0... Bug 25920: Add liblocale-codes-perl package to fix ubuntu-stable (focal) Aside from that, is that needed for 19.05.x? (recommended systems: Debian 9 & Ubuntu 18.04)
But... Why do we actually need it? It seems that we don't use it: % git grep Locale::Language cpanfile:requires 'Locale::Language', '2.07'; debian/list-deps: 'Locale::Language' => 'liblocale-codes-perl',
(In reply to Jonathan Druart from comment #14) > But... Why do we actually need it? It seems that we don't use it: > > % git grep Locale::Language > cpanfile:requires 'Locale::Language', '2.07'; > debian/list-deps: 'Locale::Language' => 'liblocale-codes-perl', it seems that 'perl' and 'perl-modules-5.30' packages need it root@kohadevbox:kohadevbox$ apt-cache rdepends liblocale-codes-perl liblocale-codes-perl Reverse Depends: perl-modules-5.30 koha-perldeps koha-core koha-common perl-modules-5.30 perl |w3c-linkchecker publican |libhtml-microformats-perl |libhtml-html5-sanity-perl |libdist-zilla-localetextdomain-perl |libbusiness-onlinepayment-ippay-perl |libbusiness-isin-perl ledgersmb auto-multiple-choice-common perl
(In reply to Mason James from comment #15) > (In reply to Jonathan Druart from comment #14) > > But... Why do we actually need it? It seems that we don't use it: > > > > % git grep Locale::Language > > cpanfile:requires 'Locale::Language', '2.07'; > > debian/list-deps: 'Locale::Language' => 'liblocale-codes-perl', > > it seems that 'perl' and 'perl-modules-5.30' packages need it > you can see it listed as a dep here... https://packages.ubuntu.com/focal/perl
ok but, why do we depend on it if another package already depends on it? :)
(In reply to Jonathan Druart from comment #17) > ok but, why do we depend on it if another package already depends on it? :) hmm yes, i agree the package should have been installed as a dependency of the 'perl' pkg. so i don't understand how it was not being installed i'll add a patch to remove the explicit dependency
Created attachment 121343 [details] [review] Bug 25920: Remove explicit dependency of liblocale-codes-perl 1/ apply patch 2/ build and install new koha-common package 3/ confirm liblocale-codes-perl pkg is installed $ apt-cache policy liblocale-codes-perl | grep Installed Installed: 3.62-1
Mason, we need a separate bug report for this last patch. The original one has been backported already.
(In reply to Jonathan Druart from comment #20) > Mason, we need a separate bug report for this last patch. The original one > has been backported already. This is still pending.
(In reply to Jonathan Druart from comment #21) > (In reply to Jonathan Druart from comment #20) > > Mason, we need a separate bug report for this last patch. The original one > > has been backported already. > > This is still pending. I've created Bug 30084 for that
(In reply to Fridolin Somers from comment #22) > (In reply to Jonathan Druart from comment #21) > > (In reply to Jonathan Druart from comment #20) > > > Mason, we need a separate bug report for this last patch. The original one > > > has been backported already. > > > > This is still pending. > I've created Bug 30084 for that thanks Frido! this can be closed now