Bug 25924 - Broken link on Coce image in staff interface bibliographic detail page
Summary: Broken link on Coce image in staff interface bibliographic detail page
Status: RESOLVED DUPLICATE of bug 25031
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on: 18421
Blocks:
  Show dependency treegraph
 
Reported: 2020-07-03 14:27 UTC by Owen Leonard
Modified: 2020-09-10 18:19 UTC (History)
0 users

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 25924: Remove broken link from detail page Coce image (1.72 KB, patch)
2020-07-03 14:32 UTC, Owen Leonard
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2020-07-03 14:27:19 UTC
When viewing the bibliographic detail page in the staff interface with Coce images enabled, the Coce cover image is wrapped in a link:

<a class="p1" href="/cgi-bin/koha/catalogue/[% DetailPage | html %]?biblionumber=[% biblionumber | url %]">

The "DetailPage" variable hasn't been defined so the link is broken. Rather than fix the variable I suggest we remove the link, since linking to the detail page from the detail page doesn't make any sense.
Comment 1 Owen Leonard 2020-07-03 14:32:47 UTC
Created attachment 106520 [details] [review]
Bug 25924: Remove broken link from detail page Coce image

This patch removes the broken link around the Coce image on the
bibliographic detail page in the staff interface. Even a working link
to the detail page from the detail page isn't useful.

To test you must have Coce configured and enabled in the staff client.

Apply the patch and view the bibliographic detail page in the staff
interface for a record which has a Coce cover image. The Coce image
should not be linked to anything.
Comment 2 Owen Leonard 2020-09-10 18:19:30 UTC
This patch was made obsolete by Bug 25031

*** This bug has been marked as a duplicate of bug 25031 ***