Bug 25928 - xt/find-license-problems.t should ignore release-tools
Summary: xt/find-license-problems.t should ignore release-tools
Status: RESOLVED MOVED
Alias: None
Product: Koha
Classification: Unclassified
Component: Test Suite (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: Chris Cormack
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-07-05 04:16 UTC by Victor Grousset/tuxayo
Modified: 2020-10-13 08:27 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Victor Grousset/tuxayo 2020-07-05 04:16:52 UTC 
If release-tools are in the Koha repo, then it picked up by this test and causes errors.
Comment 1 Victor Grousset/tuxayo 2020-07-05 04:18:00 UTC 
xt/find-license-problems.t .............................................. 1/? 
#   Failed test at xt/find-license-problems.t line 62.
#          got: '0'
#     expected: '1'
# File ./release-tools/httprecorder.pl has wrong copyright: hasgpl=1, hasv3=0, hasorlater=1, haslinktolicense=0, hasfranklinst=0

#   Failed test at xt/find-license-problems.t line 62.
#          got: '0'
#     expected: '1'
# File ./release-tools/test-release.sh has wrong copyright: hasgpl=1, hasv3=0, hasorlater=1, haslinktolicense=0, hasfranklinst=0

#   Failed test at xt/find-license-problems.t line 62.
#          got: '0'
#     expected: '1'
# File ./release-tools/get_commits.pl has wrong copyright: hasgpl=1, hasv3=0, hasorlater=1, haslinktolicense=0, hasfranklinst=0

#   Failed test at xt/find-license-problems.t line 62.
#          got: '0'
#     expected: '1'
# File ./release-tools/roll_release.sh has wrong copyright: hasgpl=1, hasv3=0, hasorlater=1, haslinktolicense=0, hasfranklinst=0

#   Failed test at xt/find-license-problems.t line 62.
#          got: '0'
#     expected: '1'
# File ./release-tools/koha-post-deploy.pl has wrong copyright: hasgpl=0, hasv3=1, hasorlater=1, haslinktolicense=1, hasfranklinst=0

#   Failed test at xt/find-license-problems.t line 62.
#          got: '0'
#     expected: '1'
# File ./release-tools/install-fresh.pl has wrong copyright: hasgpl=1, hasv3=0, hasorlater=1, haslinktolicense=0, hasfranklinst=0

#   Failed test at xt/find-license-problems.t line 62.
#          got: '0'
#     expected: '1'
# File ./release-tools/get_bugs.pl has wrong copyright: hasgpl=1, hasv3=0, hasorlater=1, haslinktolicense=0, hasfranklinst=0

#   Failed test at xt/find-license-problems.t line 62.
#          got: '0'
#     expected: '1'
# File ./release-tools/release-tool.pl has wrong copyright: hasgpl=0, hasv3=1, hasorlater=1, haslinktolicense=1, hasfranklinst=0

#   Failed test at xt/find-license-problems.t line 62.
#          got: '0'
#     expected: '1'
# File ./release-tools/reprepro/conf/changelogs.example has wrong copyright: hasgpl=1, hasv3=0, hasorlater=0, haslinktolicense=0, hasfranklinst=0
xt/find-license-problems.t .............................................. 680/? # Looks like you failed 9 tests of 1168.
Comment 2 Jonathan Druart 2020-07-29 14:58:53 UTC 
I think it should be fixed from release-tools instead.
Comment 3 Victor Grousset/tuxayo 2020-10-12 22:46:59 UTC 
Makes sense, new ticket there: https://gitlab.com/koha-community/release-tools/-/issues/19