Bug 25967 - Plugin upgrade should remove existing code before installing new code
Summary: Plugin upgrade should remove existing code before installing new code
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: Plugin architecture (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low enhancement
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-07-09 13:42 UTC by David Cook
Modified: 2020-07-09 13:42 UTC (History)
0 users

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description David Cook 2020-07-09 13:42:00 UTC
At the moment, upgrading a plugin really means overwriting the existing plugin files with new files.

This is fine for files that are added or modified, but it won't remove files that have been deleted.

Of course, we don't necessarily know what files to delete when we're upgrading a plugin, because we don't track the files, and the files can be a bit messy.

For instance, "/var/lib/koha/kohadev/plugins/Koha/Plugin/Com/ByWaterSolutions" is the root for both KitchenSink and CoverFlow.

This is probably an infeasible idea due to existing installs, but just pointing out the flaw in the plugin architecture.