Bug 26062 - Membership Expiry can not be limited by Patron Category
Summary: Membership Expiry can not be limited by Patron Category
Status: Failed QA
Alias: None
Product: Koha
Classification: Unclassified
Component: Command-line Utilities (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Tomás Cohen Arazi
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-07-24 18:17 UTC by Kelly McElligott
Modified: 2023-10-16 19:20 UTC (History)
8 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 26062: Add --category option to membership_expiry.pl (2.53 KB, patch)
2020-07-24 19:21 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Kelly McElligott 2020-07-24 18:17:10 UTC
Currently, the membership expiry cron runs and can be limited by branchcode, to exclude specific branches. 

However, it can not limit by patron category.  It would be extremely helpful for libraries to be able to utilize a different way of using this cron by allowing the  limiting by patron category.
Comment 1 Tomás Cohen Arazi 2020-07-24 19:21:41 UTC
Created attachment 107367 [details] [review]
Bug 26062: Add --category option to membership_expiry.pl

This patch adds a new option switch to the script, allowing to restrict
the query for upcoming expirying patrons to a specific category.

To test:
1. Apply this patch
2. Have upcoming expirying patrons with a certain category, and some
   others matching the expiry params (before/after), but with a
   different category
3. Run the script passing --category CAT (CAT being the chosen category)
=> SUCCESS: Only those on the specified category are picked
4. Sign off :-D

Sponsored-by: ByWater Solutions
Comment 2 Katrin Fischer 2020-07-24 21:56:18 UTC
The delay for sending the notice is already a system preference - can we have the limit as a system preference too please? This would make it much easier for installations with multiple instances.
Comment 3 Liz Rea 2020-07-31 15:46:08 UTC
I agree with Katrin here - from a sysadmin standpoint it's much better for libraries to be able to configure these from the interface (it's easier for package maintenance/upgrades too, since users won't be inclined to modify the default cron files and then have to resolve those differences at upgrade time in apt)
Comment 4 Owen Leonard 2021-02-24 19:34:47 UTC
I think comment 2 and comment 3 indicate that this should be Failed QA.
Comment 5 Fridolin Somers 2021-10-07 07:01:43 UTC
I think this is obsolete since Bug 28456 added --where arg.
Comment 6 Juliet Heltibridle 2023-10-16 17:07:45 UTC
Our library has patrons who we would like to exclude from notices to renew their accounts. It would make more sense to have this be something we could control from the staff interface, since we do not have control of the crons as a supported library.
Comment 7 Katrin Fischer 2023-10-16 19:20:49 UTC
On command line you can already achieve the limit on patron category using the --where parameter. I believe we should really move this into the GUI.