To recreate: - set finesCalendar to ignore the calendar - set circ rules to charge $1 per day, no grace period - set library as closed yesterday on calendar - check item out with due date of yesterday - run fines.pl - see patron has $1 fine - change finesCalendar to use the calendar - check item out with due date of yesterday - run fines.pl - see patron has no fine When we count billable days for the fine, we don't count the due date itself. So we should not count the due date when counting holidays to be subtracted from the billable days.
I believe the calculation to be correct. Ignore the calendar = ignore the holidays. The item is due yesterday, the first fine is calculated the following day. Assuming: * grace period = 0 * fine interval = 1 * charge at beginning of fine interval