We've moved some HTML preferences into the News tool that used to have their changes logged that are no longer logged. While we could expire an old news item and keep it as a historical log, it doesn't track with current workflows where those changes were logged before, or at least had the option to be logged.
Since the old sys prefs like OPACHeader did log changes I would not consider this an enhancement
I think this needs to be higher priority. Combined with Bug 26205 librarians are losing large sections of HTML because the WYSIWYG is doing automatic code clean up. Without logs there is no way to recover the old data.
This bug is 26205, so what I meant was Bug 26942
This is a horrible idea and not an enhancement. If the idea to clean up code, as the idea behind Bug 26942 suggests, is because users do not know what they're doing writing HTML then they should be able to have a history that they can revert back to when they lose content.
(In reply to Michael Sutherland from comment #5) > This is a horrible idea and not an enhancement. What's a horrible idea? That News changes should be logged (the purpose of this bug) or that TinyMCE shouldn't be doing automatic code changes (which is what Bug 26942 is about).
I apologize. What I meant to say is that moving the ability to edit the HTML out of system preferences and into the news without a way to track changes and the WYSIWYG editor doing automatic code changes is an awful, horrible idea and change. If this bug is meant to address those issues, then this should be a higher priority and fixed. Especially for those users that do not know HTML and how to recover from lost code.
Our consortium is using Koha in a multi-branch setup. We recently had someone in the consortium go through and clear out nearly all of the news items including the OPAC customizations without knowing the impact it would have. This resulted in the OPAC headers being deleted. We were able to restore things without too much trouble but I foresee it happening again. I would recommend that OPAC customizations be moved to an entirely new place that is protected with permissions. The ability to accidentally delete something forever from a live web page can be extremely problematic.
(In reply to Esther Melander from comment #8) > I would recommend that OPAC customizations be moved to an entirely new place > that is protected with permissions. The ability to accidentally delete > something forever from a live web page can be extremely problematic. Esther, I believe there is a system setting that protects news with permissions. Someone please correct me if I'm mistaken. If you go to 'Use all tools', under that branch is the permission 'Write news for the OPAC and staff interfaces (edit_news)'. I have not tested this to see if users may not actually access this if they do not have this permission marked.
(In reply to Michael Sutherland from comment #9) > (In reply to Esther Melander from comment #8) > > > I would recommend that OPAC customizations be moved to an entirely new place > > that is protected with permissions. The ability to accidentally delete > > something forever from a live web page can be extremely problematic. > > Esther, I believe there is a system setting that protects news with > permissions. Someone please correct me if I'm mistaken. If you go to 'Use > all tools', under that branch is the permission 'Write news for the OPAC and > staff interfaces (edit_news)'. I have not tested this to see if users may > not actually access this if they do not have this permission marked. This does work for stopping ALL news editing/creation. However we might want to let individual libraries set their own news for their patrons and not give them access to the OPAC customizations. Lisette
(In reply to Lisette Scheer from comment #10) > However we might want > to let individual libraries set their own news for their patrons and not > give them access to the OPAC customizations. > > Lisette I heartily, emphatically agree.
I created a separate bug (Bug 28059) for the separation of news and OPAC customizations since this is a different topic from logging. Though OPAC customizations are also not logged.
(In reply to Lucas Gass from comment #3) > I think this needs to be higher priority. Combined with Bug 26942 librarians > are losing large sections of HTML because the WYSIWYG is doing automatic > code clean up. Without logs there is no way to recover the old data. Agreed about it being a higher priority. I had to restore some HTML news from a backup because Bug 26942 had wiped out the CSS that they'd used.
Created attachment 120895 [details] [review] Bug 26205: Add logging of news items To test: 1. Apply patch, updatedatabase, restart_all 2. Make sure the system pref 'NewsLog' is turned on. 3. Go to the Koha News tool and create a new news item. 4. View the logs and display only the OPAC News module 5. You should see your new news, it will include the lang ( OPACheader_en ) and the content of the news item. 6. Filter the logs so the only action is 'Add', your new news item should appear 7. Modify some news items 8. They should appear in the logs now as modification. 9. Make sure you can filter the action to 'Modify' and can confirm it works 10. Delete some news items 11. 8. They should appear in the logs now as deletinon 12. Make sure you can filter the action to 'Delete' and can confirm it works
Created attachment 121338 [details] [review] Bug 26205: Add logging of news items To test: 1. Apply patch, updatedatabase, restart_all 2. Make sure the system pref 'NewsLog' is turned on. 3. Go to the Koha News tool and create a new news item. 4. View the logs and display only the OPAC News module 5. You should see your new news, it will include the lang ( OPACheader_en ) and the content of the news item. 6. Filter the logs so the only action is 'Add', your new news item should appear 7. Modify some news items 8. They should appear in the logs now as modification. 9. Make sure you can filter the action to 'Modify' and can confirm it works 10. Delete some news items 11. They should appear in the logs now as deletinon 12. Make sure you can filter the action to 'Delete' and can confirm it works Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 121603 [details] [review] Bug 26205: Add logging of news items To test: 1. Apply patch, updatedatabase, restart_all 2. Make sure the system pref 'NewsLog' is turned on. 3. Go to the Koha News tool and create a new news item. 4. View the logs and display only the OPAC News module 5. You should see your new news, it will include the lang ( OPACheader_en ) and the content of the news item. 6. Filter the logs so the only action is 'Add', your new news item should appear 7. Modify some news items 8. They should appear in the logs now as modification. 9. Make sure you can filter the action to 'Modify' and can confirm it works 10. Delete some news items 11. They should appear in the logs now as deletinon 12. Make sure you can filter the action to 'Delete' and can confirm it works Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 121604 [details] [review] Bug 26205: (QA follow-up) Capitalization: OPAC News Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 121605 [details] [review] Bug 26205: (QA follow-up) Change OPACNEWS to just NEWS As news are usable in OPAC and staff interface, I suggest changing the code to just be NEWS instead of OPACNEWS. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 121606 [details] [review] Bug 26205: (QA follow-up) Add punctuation and widen pref description a bit Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
I kept the follow-ups independent in case not all are wanted. But I feel it would be a good thing to remove the OPAC bits as the news tool can be used for both interfaces.
(In reply to Katrin Fischer from comment #20) > I kept the follow-ups independent in case not all are wanted. But I feel it > would be a good thing to remove the OPAC bits as the news tool can be used > for both interfaces. I completely agree!
Thx, Lucas!
Please fix author's email and name of the patches.
Created attachment 122229 [details] [review] Bug 26205: Add logging of news items To test: 1. Apply patch, updatedatabase, restart_all 2. Make sure the system pref 'NewsLog' is turned on. 3. Go to the Koha News tool and create a new news item. 4. View the logs and display only the OPAC News module 5. You should see your new news, it will include the lang ( OPACheader_en ) and the content of the news item. 6. Filter the logs so the only action is 'Add', your new news item should appear 7. Modify some news items 8. They should appear in the logs now as modification. 9. Make sure you can filter the action to 'Modify' and can confirm it works 10. Delete some news items 11. They should appear in the logs now as deletinon 12. Make sure you can filter the action to 'Delete' and can confirm it works Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 122231 [details] [review] Bug 26205: Add logging of news items To test: 1. Apply patch, updatedatabase, restart_all 2. Make sure the system pref 'NewsLog' is turned on. 3. Go to the Koha News tool and create a new news item. 4. View the logs and display only the OPAC News module 5. You should see your new news, it will include the lang ( OPACheader_en ) and the content of the news item. 6. Filter the logs so the only action is 'Add', your new news item should appear 7. Modify some news items 8. They should appear in the logs now as modification. 9. Make sure you can filter the action to 'Modify' and can confirm it works 10. Delete some news items 11. They should appear in the logs now as deletinon 12. Make sure you can filter the action to 'Delete' and can confirm it works Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 122232 [details] [review] Bug 26205: (QA follow-up) Capitalization: OPAC News Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 122233 [details] [review] Bug 26205: (QA follow-up) Change OPACNEWS to just NEWS As news are usable in OPAC and staff interface, I suggest changing the code to just be NEWS instead of OPACNEWS. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 122234 [details] [review] Bug 26205: (QA follow-up) Add punctuation and widen pref description a bit Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
This needs to be called "additional contents", see bug 24387. I am inclined to push as it, but keep it in mind for next time.
Pushed to master for 21.11, thanks to everybody involved!
Backported to 21.05.x for 21.05.02
Does not apply on 20.11.x , mainly because of Bug 14233.
Here we are adding a new syspref "NewsLog" which will use "NEWS" for module. It will be released in 21.11.00 alongwith bug 24387 that is renaming the whole tool "Additional contents", as well as the syspref NewsToolEditor => AdditionalContentsEditor I am suggesting to rename the syspref NewsLog => AdditionalContentsLog, and use "ADDITIONAL_CONTENTS" for module in the action_logs table. Would that work for you?
Erk, it has been backported.