Strings defined for translation in subscription-add.tt can now be wrapped in the new translation function and put in subscription-add.js.
Created attachment 126675 [details] [review] Bug 26257: Move translatable strings out of subscription-add.tt and into subscription-add.js This patch removes the definition of translatable strings out of templates and into the corresponding JavaScript file, using the new JS i81n function. To test: - Apply the patch and go to Serials -> New subscription - Click "Next" without filling out any fields. You should get two confirmations, "If you wish to claim late or missing issues you must link this subscription to a vendor. Click OK to ignore or Cancel to return and enter a vendor" and "You must choose or create a bibliographic record." - Manually enter a vendor number which doesn't exist and click "Next." Error: "The vendor does not exist." - Manually enter a record number which doesn't exist and click "Next." Error: "Bibliographic record does not exist!" - Select a valid vendor and bibliographic record and proceed to the next page. - Click "Test prediction pattern" without filling in any fields. Error: "Cannot test prediction pattern for the following reason(s): Frequency is not defined. - First publication date is not defined" - Click "Save subscription" without filling in any information. Error: "You must choose a first publication date." - Fill in a date and click "Save subscription." Error: "You must choose a subscription length or an end date." - Enter a frequency and subscription start date and click "Save subscription." Error: "Please click on 'Test prediction pattern' before saving subscription." - Click "Show advanced pattern" and then "Save subscription." Error: "You have modified the advanced prediction pattern. Please save your work or cancel modifications." Testing numbering patterns: - There are several strings related to setting and editing numbering patterns but I don't think they can be tested live while Bug 28012 is unfixed. Testing Mana integration: - To test Mana integration you must have Mana enabled, and a bibliographic record in your catalog which has an ISSN matching a record in Mana. You can go to "Search on Mana" from the Serials sidebar menu to locate a working record. - Add a subscription using the bibliographic record which will match a record in Mana. When you click "Next" you should see a message at the top of the page saying, "Searching for subscription in Mana Knowledge Base" - After a moment this message should be replaced with "Subscription found on Mana Knowledge Base: Show Mana results" - Clicking the "Show Mana results" should trigger a modal window with the heading "Results from Mana Knowledge Base." - Test the subscription add process using a bibliographic record which doesn't match anything in Mana. The message at the top of the page should read, "No subscription found on Mana Knowledge Base" TESTING TRANSLATABILITY - Update a translation, e.g. fr-FR: > cd misc/translator > perl translate update fr-FR - Open the corresponding .po file for JavaScript strings, e.g. misc/translator/po/fr-FR-messages-js.po - Locate strings pulled from koha-tmpl/intranet-tmpl/prog/js/subscription-add.js for translation, e.g.: msgid "Next issue publication date is not defined" msgstr "" - Edit the "msgstr" string however you want (it's just for testing). - Install the updated translation: > perl translate install fr-FR - Switch to your newly translated language in the staff client and repeat the test plan above. The translated strings should appear.
Sorry this test plan is so long! I tried to describe how to trigger as many of the translatable strings as possible.
Created attachment 128058 [details] [review] Bug 26257: Move translatable strings out of subscription-add.tt and into subscription-add.js This patch removes the definition of translatable strings out of templates and into the corresponding JavaScript file, using the new JS i81n function. To test: - Apply the patch and go to Serials -> New subscription - Click "Next" without filling out any fields. You should get two confirmations, "If you wish to claim late or missing issues you must link this subscription to a vendor. Click OK to ignore or Cancel to return and enter a vendor" and "You must choose or create a bibliographic record." - Manually enter a vendor number which doesn't exist and click "Next." Error: "The vendor does not exist." - Manually enter a record number which doesn't exist and click "Next." Error: "Bibliographic record does not exist!" - Select a valid vendor and bibliographic record and proceed to the next page. - Click "Test prediction pattern" without filling in any fields. Error: "Cannot test prediction pattern for the following reason(s): Frequency is not defined. - First publication date is not defined" - Click "Save subscription" without filling in any information. Error: "You must choose a first publication date." - Fill in a date and click "Save subscription." Error: "You must choose a subscription length or an end date." - Enter a frequency and subscription start date and click "Save subscription." Error: "Please click on 'Test prediction pattern' before saving subscription." - Click "Show advanced pattern" and then "Save subscription." Error: "You have modified the advanced prediction pattern. Please save your work or cancel modifications." Testing numbering patterns: - There are several strings related to setting and editing numbering patterns but I don't think they can be tested live while Bug 28012 is unfixed. Testing Mana integration: - To test Mana integration you must have Mana enabled, and a bibliographic record in your catalog which has an ISSN matching a record in Mana. You can go to "Search on Mana" from the Serials sidebar menu to locate a working record. - Add a subscription using the bibliographic record which will match a record in Mana. When you click "Next" you should see a message at the top of the page saying, "Searching for subscription in Mana Knowledge Base" - After a moment this message should be replaced with "Subscription found on Mana Knowledge Base: Show Mana results" - Clicking the "Show Mana results" should trigger a modal window with the heading "Results from Mana Knowledge Base." - Test the subscription add process using a bibliographic record which doesn't match anything in Mana. The message at the top of the page should read, "No subscription found on Mana Knowledge Base" TESTING TRANSLATABILITY - Update a translation, e.g. fr-FR: > cd misc/translator > perl translate update fr-FR - Open the corresponding .po file for JavaScript strings, e.g. misc/translator/po/fr-FR-messages-js.po - Locate strings pulled from koha-tmpl/intranet-tmpl/prog/js/subscription-add.js for translation, e.g.: msgid "Next issue publication date is not defined" msgstr "" - Edit the "msgstr" string however you want (it's just for testing). - Install the updated translation: > perl translate install fr-FR - Switch to your newly translated language in the staff client and repeat the test plan above. The translated strings should appear. Signed-off-by: David Nind <david@davidnind.com>
(In reply to Owen Leonard from comment #2) > Sorry this test plan is so long! I tried to describe how to trigger as many > of the translatable strings as possible. I like long test plans! 8-)
Created attachment 128059 [details] Bug 26257 - Screenshot - Formatting of test prediction pattern error message A couple of minor formatting suggestions for the messages. Full stops at the end of these sentences - some have, some don't - I am not sure of the correct rule for these: - The vendor does not exist - You must choose a first publication date Formatting of test prediction pattern error message (see screenshot from Firefox): - No carriage return before the first reason - No space between the - and the first letter for the second error ==> should ideally appear as: Cannot test prediction pattern for the following reason(s): - Frequency is not defined. - First publication date is not defined.
Created attachment 130026 [details] [review] Bug 26257: Move translatable strings out of subscription-add.tt and into subscription-add.js This patch removes the definition of translatable strings out of templates and into the corresponding JavaScript file, using the new JS i81n function. To test: - Apply the patch and go to Serials -> New subscription - Click "Next" without filling out any fields. You should get two confirmations, "If you wish to claim late or missing issues you must link this subscription to a vendor. Click OK to ignore or Cancel to return and enter a vendor" and "You must choose or create a bibliographic record." - Manually enter a vendor number which doesn't exist and click "Next." Error: "The vendor does not exist." - Manually enter a record number which doesn't exist and click "Next." Error: "Bibliographic record does not exist!" - Select a valid vendor and bibliographic record and proceed to the next page. - Click "Test prediction pattern" without filling in any fields. Error: "Cannot test prediction pattern for the following reason(s): Frequency is not defined. - First publication date is not defined" - Click "Save subscription" without filling in any information. Error: "You must choose a first publication date." - Fill in a date and click "Save subscription." Error: "You must choose a subscription length or an end date." - Enter a frequency and subscription start date and click "Save subscription." Error: "Please click on 'Test prediction pattern' before saving subscription." - Click "Show advanced pattern" and then "Save subscription." Error: "You have modified the advanced prediction pattern. Please save your work or cancel modifications." Testing numbering patterns: - There are several strings related to setting and editing numbering patterns but I don't think they can be tested live while Bug 28012 is unfixed. Testing Mana integration: - To test Mana integration you must have Mana enabled, and a bibliographic record in your catalog which has an ISSN matching a record in Mana. You can go to "Search on Mana" from the Serials sidebar menu to locate a working record. - Add a subscription using the bibliographic record which will match a record in Mana. When you click "Next" you should see a message at the top of the page saying, "Searching for subscription in Mana Knowledge Base" - After a moment this message should be replaced with "Subscription found on Mana Knowledge Base: Show Mana results" - Clicking the "Show Mana results" should trigger a modal window with the heading "Results from Mana Knowledge Base." - Test the subscription add process using a bibliographic record which doesn't match anything in Mana. The message at the top of the page should read, "No subscription found on Mana Knowledge Base" TESTING TRANSLATABILITY - Update a translation, e.g. fr-FR: > cd misc/translator > perl translate update fr-FR - Open the corresponding .po file for JavaScript strings, e.g. misc/translator/po/fr-FR-messages-js.po - Locate strings pulled from koha-tmpl/intranet-tmpl/prog/js/subscription-add.js for translation, e.g.: msgid "Next issue publication date is not defined" msgstr "" - Edit the "msgstr" string however you want (it's just for testing). - Install the updated translation: > perl translate install fr-FR - Switch to your newly translated language in the staff client and repeat the test plan above. The translated strings should appear. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 22.05, thanks to everybody involved [U+1F984]