Bug 26350 - Librarians can request discharge on behalf of patron
Summary: Librarians can request discharge on behalf of patron
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Patrons (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Dobrica Pavlinusic
QA Contact: Testopia
URL: /cgi-bin/koha/members/discharge.pl
Keywords:
Depends on:
Blocks:
 
Reported: 2020-09-02 10:53 UTC by Dobrica Pavlinusic
Modified: 2023-09-22 21:00 UTC (History)
4 users (show)

See Also:
Change sponsored?: Sponsored
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 26350: Librarians can request discharge on behalf of patron (3.12 KB, patch)
2020-09-02 12:31 UTC, Dobrica Pavlinusic
Details | Diff | Splinter Review
Bug 26350: Librarians can request discharge on behalf of patron (3.12 KB, patch)
2020-09-02 12:37 UTC, Dobrica Pavlinusic
Details | Diff | Splinter Review
Bug 26350: Librarians can request discharge on behalf of patron (3.18 KB, patch)
2020-09-02 15:02 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 26350: Librarians can request discharge on behalf of patron (3.23 KB, patch)
2020-09-02 17:45 UTC, Nick Clemens (kidclamp)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Dobrica Pavlinusic 2020-09-02 10:53:15 UTC
While deploying discharges in our library we figured out that librarians need ability to request discharge document on behalf of patrons from intranet page.

It was logical to add another option on Discharge patron tab.
Comment 1 Dobrica Pavlinusic 2020-09-02 12:31:49 UTC Comment hidden (obsolete)
Comment 2 Dobrica Pavlinusic 2020-09-02 12:37:55 UTC
Created attachment 109516 [details] [review]
Bug 26350: Librarians can request discharge on behalf of patron

While deploying discharges in our library we figured out that librarians
need ability to request discharge document on behalf of patrons from
intranet page.

It was logical to add another option on Discharge patron tab.

It nicely addresses Bug 16466 since it shows status of pending
discharge instead of button to issue new discharge.

To test:
1. apply patch
2. make sure that useDischarge is enabled in administration
3. verify that "Request new discharge" button is availabe, click on it
4. after page reload, message "Patron has pending discharge request."
   will appear
5. click on "Generate discharge" to approve discharge and generate
   pdf (this is unchanged compared to exsting workflow)
Comment 3 Dobrica Pavlinusic 2020-09-02 12:38:45 UTC
Removed one extra empty line in second version of patch.
Comment 4 Owen Leonard 2020-09-02 15:02:14 UTC
Created attachment 109545 [details] [review]
Bug 26350: Librarians can request discharge on behalf of patron

While deploying discharges in our library we figured out that librarians
need ability to request discharge document on behalf of patrons from
intranet page.

It was logical to add another option on Discharge patron tab.

It nicely addresses Bug 16466 since it shows status of pending
discharge instead of button to issue new discharge.

To test:
1. apply patch
2. make sure that useDischarge is enabled in administration
3. verify that "Request new discharge" button is availabe, click on it
4. after page reload, message "Patron has pending discharge request."
   will appear
5. click on "Generate discharge" to approve discharge and generate
   pdf (this is unchanged compared to exsting workflow)

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 5 Nick Clemens (kidclamp) 2020-09-02 17:45:22 UTC
Created attachment 109557 [details] [review]
Bug 26350: Librarians can request discharge on behalf of patron

While deploying discharges in our library we figured out that librarians
need ability to request discharge document on behalf of patrons from
intranet page.

It was logical to add another option on Discharge patron tab.

It nicely addresses Bug 16466 since it shows status of pending
discharge instead of button to issue new discharge.

To test:
1. apply patch
2. make sure that useDischarge is enabled in administration
3. verify that "Request new discharge" button is availabe, click on it
4. after page reload, message "Patron has pending discharge request."
   will appear
5. click on "Generate discharge" to approve discharge and generate
   pdf (this is unchanged compared to exsting workflow)

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 6 Katrin Fischer 2020-09-02 18:29:18 UTC
This went through so fast... I didn't even get a chance to say hi to Dobrica yet!
Comment 7 Jonathan Druart 2020-09-03 09:47:13 UTC
Hi Dobrica, good to see you around :)

Can you explain the use case please, I am not sure I understand it.

If a librarian wants to let a patron download their discharge from the OPAC, the librarian can generate the discharge from the staff interface. The patron will then see a "Get your discharge" link on their account.

I don't see the point of this extra step actually: a librarian request a discharge which will need to be approved.
Comment 8 Dobrica Pavlinusic 2020-09-03 10:25:41 UTC
That is true for the first discharge. After that, Generate discharge will always return just last discharge.

If patron restriction is removed, patrons can request another discharge on opac, but librarians can't do that in current implementation.

We are discharging students at the end of every year and sending discharges to the student services, so that students can enroll in next year.

For us, it's essential to be able to generate discharge even if there is existing one, without the need for a student to do anything since we do have students with special needs which are unable to use opac (or web at all).

After students enroll in the next year, we remove patron restriction and repeat the whole process for each year they are with us.

Does this make more sense now?

For us, librarians who request discharges are not the same ones who will allow it.

We have local changes that also track librarian borrowernumber to be able to print name of a librarian who approved a discharge, but that will require cleanup (and implementation of permissions) before we can submit that part.
Comment 9 Dobrica Pavlinusic 2020-09-04 10:19:20 UTC
I found additional bug when using Generate discharge without creating request through OPAC or this patch: field needed in discharges table never gets filled and is NULL.

This is again problem for us, since we want to include date and time of discharge request.
Comment 10 Katrin Fischer 2023-09-22 21:00:08 UTC
I believe this has been fixed: When UseDischarge is activated, we have a "Generate discharge" button on the Discharges tab in the patron account.