Bug 26354 - Prevent submission of patron modification request unless changes are actually made
Summary: Prevent submission of patron modification request unless changes are actually...
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks: 25063
  Show dependency tree / graph
 
Reported: 2020-09-02 14:56 UTC by Christopher Brannon
Modified: 2023-06-22 18:43 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Christopher Brannon 2020-09-02 14:56:52 UTC 
I think there should be an preference to not be able to submit a request unless information has been changed.

We frequently get modification requests with no changes made at all.
Comment 1 Owen Leonard 2020-09-02 15:17:25 UTC 
I see two angles on this--perhaps both?

1. We check for changes to the form and ask the user if they really mean to submit a form without having made changes.

2. We silently reject submissions with no changes. Somehow this seems nicer than telling the user they can't submit the form.
Comment 2 Christopher Brannon 2020-09-02 15:48:08 UTC 
(In reply to Owen Leonard from comment #1)
> I see two angles on this--perhaps both?
> 
> 1. We check for changes to the form and ask the user if they really mean to
> submit a form without having made changes.
> 
> 2. We silently reject submissions with no changes. Somehow this seems nicer
> than telling the user they can't submit the form.

What about a modal, summarizing the changes?  If there are no changes, it says "No changes have been made."

Thoughts?