https://www.oclc.org/bibformats/en/fixedfield/elvl.html
Created attachment 109622 [details] [review] Bug 26368: Add OCLC options to marc21_leader.tt See documentation at: https://www.oclc.org/bibformats/en/fixedfield/elvl.html To test: 1 - Apply patch 2 - Edit a record 3 - Edit the leader 4 - Note the new options 5 - Set the value of encodign level to the new options and save 6 - Edit again 7 - Confirm the value is displayed correctly selected
If these are no MARC standard and OCLC is only used by a quite small percentage of libraries using Koha - could we make displaying these optional? Maybe we could introduce a second plugin that can be linked in frameworks or a general "OCLC participant" pref to switch on such things
Especially since the options are currently not marked as OCLC specific - I think they should be.
Created attachment 120209 [details] [review] Bug 26368: Add OCLC options to marc21_leader.tt See documentation at: https://www.oclc.org/bibformats/en/fixedfield/elvl.html To test: 1 - Apply patch, updatedatabase 2 - Edit a record in the basic editor 3 - Edit the leader using the plugin 4 - Note the options for '17 - Encoding level' 5 - Find the system preference 'UseOCLCEncodingLevels' 6 - Edit the record again 7 - Note new options I,J,K,M 8 - Set the value of encodign level to one of the new options and save 9 - Edit again 10 - Confirm the value is displayed correctly selected 11 - Repeat tests using advanced cataloging editor
Patch no longer applies 8-(.. git bz apply 26368 Bug 26368 - Add support for OCLC Encoding level values 120209 - Bug 26368: Add OCLC options to marc21_leader.tt Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 26368: Add OCLC options to marc21_leader.tt Using index info to reconstruct a base tree... M installer/data/mysql/mandatory/sysprefs.sql M koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/cataloguing.pref M koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/marc21_leader.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/marc21_leader.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/cataloguing.pref Auto-merging installer/data/mysql/mandatory/sysprefs.sql CONFLICT (content): Merge conflict in installer/data/mysql/mandatory/sysprefs.sql error: Failed to merge in the changes. Patch failed at 0001 Bug 26368: Add OCLC options to marc21_leader.tt
Created attachment 140826 [details] [review] Bug 26368: Add OCLC options to marc21_leader.tt See documentation at: https://www.oclc.org/bibformats/en/fixedfield/elvl.html To test: 1 - Apply patch, updatedatabase 2 - Edit a record in the basic editor 3 - Edit the leader using the plugin 4 - Note the options for '17 - Encoding level' 5 - Find the system preference 'UseOCLCEncodingLevels' 6 - Edit the record again 7 - Note new options I,J,K,M 8 - Set the value of encodign level to one of the new options and save 9 - Edit again 10 - Confirm the value is displayed correctly selected 11 - Repeat tests using advanced cataloging editor
Created attachment 140837 [details] [review] Bug 26368: Add OCLC options to marc21_leader.tt See documentation at: https://www.oclc.org/bibformats/en/fixedfield/elvl.html To test: 1 - Apply patch, updatedatabase 2 - Edit a record in the basic editor 3 - Edit the leader using the plugin 4 - Note the options for '17 - Encoding level' 5 - Find the system preference 'UseOCLCEncodingLevels' 6 - Edit the record again 7 - Note new options I,J,K,M 8 - Set the value of encodign level to one of the new options and save 9 - Edit again 10 - Confirm the value is displayed correctly selected 11 - Repeat tests using advanced cataloging editor Signed-off-by: David Nind <david@davidnind.com>
Created attachment 141197 [details] [review] Bug 26368: Add OCLC options to marc21_leader.tt See documentation at: https://www.oclc.org/bibformats/en/fixedfield/elvl.html To test: 1 - Apply patch, updatedatabase 2 - Edit a record in the basic editor 3 - Edit the leader using the plugin 4 - Note the options for '17 - Encoding level' 5 - Find the system preference 'UseOCLCEncodingLevels' 6 - Edit the record again 7 - Note new options I,J,K,M 8 - Set the value of encodign level to one of the new options and save 9 - Edit again 10 - Confirm the value is displayed correctly selected 11 - Repeat tests using advanced cataloging editor Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 141198 [details] [review] Bug 26368: Rephase system preference to sentence style The preference was using a yes/no instead of the more common display/don't display. This patch switches it to the latter and adds a note about position 17. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 141199 [details] [review] Bug 26368: (QA follow-up) Standardize spaces in option descriptions Most options are labelles as x- description, but a few had additional spaces. This just makes sure they all look the same. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 22.11. Nice work everyone, thanks!
Enhancement will not be backported to 22.05.x series