th should contain the NoExport class to prevent these columns to be exported.
It's "noExport".
Created attachment 115237 [details] [review] Bug 26602: Don't export "actions" column This patch add the noExport class to all "Actions" columns in the codebase. It's a stupid search and replace, maybe the class is added to table where there is no export button. Test plan: Search tables where the export button is available. Confirm that the "Actions" columns is not exported. Example: /admin/branches.pl, /admin/cities.pl
Created attachment 115249 [details] [review] Bug 26602: Don't export "actions" column This patch add the noExport class to all "Actions" columns in the codebase. It's a stupid search and replace, maybe the class is added to table where there is no export button. Test plan: Search tables where the export button is available. Confirm that the "Actions" columns is not exported. Example: /admin/branches.pl, /admin/cities.pl Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>
Created attachment 116433 [details] [review] Bug 26602: Don't export "actions" column This patch add the noExport class to all "Actions" columns in the codebase. It's a stupid search and replace, maybe the class is added to table where there is no export button. Test plan: Search tables where the export button is available. Confirm that the "Actions" columns is not exported. Example: /admin/branches.pl, /admin/cities.pl Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Created attachment 116434 [details] [review] Bug 26602: (QA follow-up) Cleanup datatables settings On letter.tt we had nosort and set things via settings that are default in KohaTable so removed those from letter.js. Also made the last updated column exportable On upload.tt the noExport didn't do anything, because we couldn't export, so moved to used KohaTable Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Pushed to master for 21.05, thanks to everybody involved!
Pushed to 20.11.x for 20.11.03
Doesn't apply cleanly to 20.05. Please rebase if needed
Created attachment 117203 [details] [review] Bug 26602: [20.05.x] Don't export "actions" column This patch add the noExport class to all "Actions" columns in the codebase. It's a stupid search and replace, maybe the class is added to table where there is no export button. Test plan: Search tables where the export button is available. Confirm that the "Actions" columns is not exported. Example: /admin/branches.pl, /admin/cities.pl Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Bug 26602: (QA follow-up) Cleanup datatables settings On letter.tt we had nosort and set things via settings that are default in KohaTable so removed those from letter.js. Also made the last updated column exportable On upload.tt the noExport didn't do anything, because we couldn't export, so moved to used KohaTable Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Created attachment 117212 [details] [review] Bug 26602: [20.05.x] Don't export "actions" column This patch add the noExport class to all "Actions" columns in the codebase. It's a stupid search and replace, maybe the class is added to table where there is no export button. Test plan: Search tables where the export button is available. Confirm that the "Actions" columns is not exported. Example: /admin/branches.pl, /admin/cities.pl Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Bug 26602: (QA follow-up) Cleanup datatables settings On letter.tt we had nosort and set things via settings that are default in KohaTable so removed those from letter.js. Also made the last updated column exportable On upload.tt the noExport didn't do anything, because we couldn't export, so moved to used KohaTable Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Bug 26602: Rebase fixes
Pushed to 20.05.x for 20.05.09
Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed.
Created attachment 117216 [details] [review] Bug 26602:[20.05.x] Remove stray merge marker