Added by bug 14610 but never used. It appears in the "local use" pref tab.
Created attachment 111945 [details] [review] Bug 26638: Remove unused system preference ArticleRequestsMandatoryFieldsItemsOnly The preference was probably added because of a typo, as there is a used system preference ArticleRequestsMandatoryFieldsItemOnly (Item vs Items). This patch fixes the situation: - syspref.sql had the pref name with the typo, this is fixed. - A database update removes the unused variable and makes sure the used one is added. To test: - Look at the local use system preferences, verify the false pref is there - Look at the other ArticleRequests* preferences, verify the other without "s" is there - Apply patch and run database update - Verify the local use tab one is gone now
Created attachment 112483 [details] [review] Bug 26638: Remove unused system preference ArticleRequestsMandatoryFieldsItemsOnly The preference was probably added because of a typo, as there is a used system preference ArticleRequestsMandatoryFieldsItemOnly (Item vs Items). This patch fixes the situation: - syspref.sql had the pref name with the typo, this is fixed. - A database update removes the unused variable and makes sure the used one is added. To test: - Look at the local use system preferences, verify the false pref is there - Look at the other ArticleRequests* preferences, verify the other without "s" is there - Apply patch and run database update - Verify the local use tab one is gone now Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Created attachment 112894 [details] [review] Bug 26638: Remove unused system preference ArticleRequestsMandatoryFieldsItemsOnly The preference was probably added because of a typo, as there is a used system preference ArticleRequestsMandatoryFieldsItemOnly (Item vs Items). This patch fixes the situation: - syspref.sql had the pref name with the typo, this is fixed. - A database update removes the unused variable and makes sure the used one is added. To test: - Look at the local use system preferences, verify the false pref is there - Look at the other ArticleRequests* preferences, verify the other without "s" is there - Apply patch and run database update - Verify the local use tab one is gone now Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Confirmed the preference is not used, confirmed the DB update is idempotent, confirmed the QA tests pass. Passing QA.
Pushed to master for 20.11, thanks to everybody involved!