There's no need to have a marc column in the auth_header table anymore. We'll need to change at least the following files: ./installer/data/mysql/kohastructure.sql ./C4/AuthoritiesMarc.pm (AddAuthority, ) t/db_dependent/Linker_FirstMatch.t We'll also need to drop the column using updatedatabase.pl: ./installer/data/mysql/updatedatabase.pl
Actually, we'll also need to re-generate Koha/Schema/Result/AuthHeader.pm
Created attachment 111670 [details] [review] Bug 26684: Remove marc from auth_header for new installs
Created attachment 111671 [details] [review] Bug 26684: Remove marc column from existing databases
Created attachment 111672 [details] [review] Bug 26684: [Do not push] Remember to update Koha::Schema::Result::AuthHeader
Created attachment 112016 [details] [review] Bug 26684: Remove marc from auth_header for new installs Signed-off-by: Didier Gautheron <didier.gautheron@biblibre.com>
Created attachment 112018 [details] [review] Bug 26684: Remove marc from auth_header for new installs Signed-off-by: Didier Gautheron <didier.gautheron@biblibre.com>
Created attachment 112019 [details] [review] Bug 26684: Remove marc column from existing databases Signed-off-by: Didier Gautheron <didier.gautheron@biblibre.com>
Qa tools complaints: FAIL installer/data/mysql/atomicupdate/001-26684-drop_marc_column_from_auth_header.pl FAIL critic Code before strictures are enabled at line 1, column 1. See page 429 of PBP. FAIL file permissions File must have the exec flag FAIL valid Name "main::dbh" used only once: possible typo if you move the file to 'perl' many disappear, however, the bug number is missing from the update so it fails right now, also we should check the existence of the column before droppping
Created attachment 112087 [details] [review] Bug 26684: Remove marc from auth_header for new installs
Created attachment 112088 [details] [review] Bug 26684: Remove marc column from existing databases
Created attachment 112089 [details] [review] Bug 26684: [Do not push] Remember to update Koha::Schema::Result::AuthHeader
Created attachment 112090 [details] [review] Bug 26684: Fix atomic update
QA scripts and updatedatabase.pl should be happy now
Patch no longer applies 8-(.. Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 26684: Remove marc from auth_header for new installs Using index info to reconstruct a base tree... M C4/AuthoritiesMarc.pm M installer/data/mysql/kohastructure.sql Falling back to patching base and 3-way merge... Auto-merging installer/data/mysql/kohastructure.sql CONFLICT (content): Merge conflict in installer/data/mysql/kohastructure.sql Auto-merging C4/AuthoritiesMarc.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 26684: Remove marc from auth_header for new installs Also, is there a test plan? I have no idea how to test this one...