On the "Notices" tab on patron account, it's not possible to sort the table using the "Updated on" column (seen on Master and 20.05). Maybe it should be on another bug, but it seems more relevant to me if this table is sort on the most recent notices first.
Hi Severine, linking this to the bug where I created the column.
Oh - I was thinking of another updated on column! Removing link, wasn't my fault! :)
Created attachment 112082 [details] [review] Bug 26686: Fix sorting of "updated on" and "time created" on notices tab In the patron's account in the staff interface there is a tab 'Notices' that shows all notices sent out to a patron. The updated on column would not sort at all, but there was also some markup missing for the time created column. To test: - Make sure you have a patron account with some notices, ideally with different times and dates - Verify that the updated on column doesn't sort at all - Apply patch - Verify both date columns now sort correctly for different DateFormat settings
Created attachment 112244 [details] [review] Bug 26686: Fix sorting of "updated on" and "time created" on notices tab In the patron's account in the staff interface there is a tab 'Notices' that shows all notices sent out to a patron. The updated on column would not sort at all, but there was also some markup missing for the time created column. To test: - Make sure you have a patron account with some notices, ideally with different times and dates - Verify that the updated on column doesn't sort at all - Apply patch - Verify both date columns now sort correctly for different DateFormat settings Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Created attachment 112360 [details] [review] Bug 26686: Fix sorting of "updated on" and "time created" on notices tab In the patron's account in the staff interface there is a tab 'Notices' that shows all notices sent out to a patron. The updated on column would not sort at all, but there was also some markup missing for the time created column. To test: - Make sure you have a patron account with some notices, ideally with different times and dates - Verify that the updated on column doesn't sort at all - Apply patch - Verify both date columns now sort correctly for different DateFormat settings Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Pushed to master for 20.11, thanks to everybody involved!
backported to 20.05.x for 20.05.06
enhancement, not backported to 19.11.x