Bug 26687 - Add a Font Awesome icon for superlibrarian patrons
Summary: Add a Font Awesome icon for superlibrarian patrons
Status: Passed QA
Alias: None
Product: Koha
Classification: Unclassified
Component: Patrons (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Fridolin SOMERS
QA Contact: Katrin Fischer
URL:
Keywords: Academy
Depends on: 26534
Blocks:
  Show dependency treegraph
 
Reported: 2020-10-15 08:47 UTC by Fridolin SOMERS
Modified: 2020-10-23 10:36 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Who signed the patch off:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 26687: Add color to Font Awesome icon for superlibrarian patrons (2.31 KB, patch)
2020-10-15 08:57 UTC, Fridolin SOMERS
Details | Diff | Splinter Review
Bug 26687: Add color to Font Awesome icon for superlibrarian patrons (2.36 KB, patch)
2020-10-16 12:50 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 26687: Add color to Font Awesome icon for superlibrarian patrons (2.42 KB, patch)
2020-10-16 13:38 UTC, Martin Renvoize
Details | Diff | Splinter Review
Screenshot (40.16 KB, image/png)
2020-10-22 07:49 UTC, Fridolin SOMERS
Details
Bug 26687: Add a Font Awesome icon for superlibrarian patrons (2.05 KB, patch)
2020-10-22 07:51 UTC, Fridolin SOMERS
Details | Diff | Splinter Review
Bug 26687: Add a Font Awesome icon for superlibrarian patrons (2.19 KB, patch)
2020-10-23 10:24 UTC, Séverine Queune
Details | Diff | Splinter Review
Bug 26687: Add a Font Awesome icon for superlibrarian patrons (2.25 KB, patch)
2020-10-23 10:36 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Fridolin SOMERS 2020-10-15 08:47:41 UTC
Bug 26534 adds a shield Font Awesome icon to help identify staff patrons.
I propose to color this icon when patron is a superlibrarian.
Comment 1 Fridolin SOMERS 2020-10-15 08:57:09 UTC
Created attachment 111686 [details] [review]
Bug 26687: Add color to Font Awesome icon for superlibrarian patrons

Bug 26534 adds a shield Font Awesome icon to help identify staff patrons.
I propose to color this icon when patron is a superlibrarian.

Patch adds 'is-superlibrarian' class that may be used for more CSS tuning.

Test plan:
1) Update staff CSS (yarn build)
2) Compare display between a patron A beeing superlibarian and a patron B having only staff interface access
3) Patron B has unchanged black shield icon
4) Patron A has red shield icon
5) Check a patron without permissions has no shield icon
Comment 2 Owen Leonard 2020-10-16 12:50:10 UTC
Created attachment 111871 [details] [review]
Bug 26687: Add color to Font Awesome icon for superlibrarian patrons

Bug 26534 adds a shield Font Awesome icon to help identify staff
patrons. I propose to color this icon when patron is a superlibrarian.

Patch adds 'is-superlibrarian' class that may be used for more CSS
tuning.

Test plan:
1) Update staff CSS (yarn build)
2) Compare display between a patron A beeing superlibarian and a patron
   B having only staff interface access
3) Patron B has unchanged black shield icon
4) Patron A has red shield icon
5) Check a patron without permissions has no shield icon

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 3 Martin Renvoize 2020-10-16 13:38:46 UTC
Created attachment 111875 [details] [review]
Bug 26687: Add color to Font Awesome icon for superlibrarian patrons

Bug 26534 adds a shield Font Awesome icon to help identify staff
patrons. I propose to color this icon when patron is a superlibrarian.

Patch adds 'is-superlibrarian' class that may be used for more CSS
tuning.

Test plan:
1) Update staff CSS (yarn build)
2) Compare display between a patron A beeing superlibarian and a patron
   B having only staff interface access
3) Patron B has unchanged black shield icon
4) Patron A has red shield icon
5) Check a patron without permissions has no shield icon

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 4 Martin Renvoize 2020-10-16 13:41:07 UTC
Nice enhancement, works as expected.. Passing QA
Comment 5 Martin Renvoize 2020-10-16 13:43:38 UTC
Minor point.. I wonder if there's any more accessible ways of highlighting this too... we might find colour blindness issues.. I'm no expert.  Either way I think that can be for another day.
Comment 6 Owen Leonard 2020-10-16 14:04:27 UTC
(In reply to Martin Renvoize from comment #5)
> we might find colour blindness issues...

I agree and I should have considered that when testing. I suggest an alternate icon. Maybe https://fontawesome.com/v4.7.0/icon/star ?
Comment 7 David Cook 2020-10-19 00:57:37 UTC
I agree with Martin. It's been years since I delved into accessibility research, but I do recall that using colour as the sole signifier of something makes something less accessible.

I like your idea, Owen, of using the star!
Comment 8 David Cook 2020-10-19 00:59:15 UTC
Maybe a superlibrarian should have the shield to denote staff status *plus* a star to denote superlibrarian status?

That might also be a nice visual sanity check to make sure that only staff are superlibrarians heh.
Comment 9 Fridolin SOMERS 2020-10-19 15:03:33 UTC
(In reply to Owen Leonard from comment #6)
> (In reply to Martin Renvoize from comment #5)
> > we might find colour blindness issues...
> 
> I agree and I should have considered that when testing. I suggest an
> alternate icon. Maybe https://fontawesome.com/v4.7.0/icon/star ?

I agree that color is not the best.

But I think we should keep star icon to mean 'favorite' or 'VIP' (like in many softwares).

I'm searching another icon.

Or maybe 2 shields ?
Comment 10 Fridolin SOMERS 2020-10-19 15:08:49 UTC
Heeeee why not :
https://fontawesome.com/v4.7.0/icon/superpowers
Comment 11 Owen Leonard 2020-10-19 16:40:09 UTC
(In reply to Fridolin SOMERS from comment #10)
> https://fontawesome.com/v4.7.0/icon/superpowers

That symbol doesn't mean anything to me! I guess it's a brand logo?
Comment 12 Owen Leonard 2020-10-19 16:41:02 UTC
https://fontawesome.com/v4.7.0/icon/bolt ?
Comment 13 Martin Renvoize 2020-10-19 17:10:24 UTC
I'd be happy with either a different icon or a visible change on the background colour.. i.e some striped or zigzags or something.. both would satisfy the accessibility requirements.
Comment 14 Martin Renvoize 2020-10-19 17:13:29 UTC
https://fontawesome.com/icons/user-secret to throw another into the mix
Comment 15 David Cook 2020-10-19 23:17:52 UTC
(In reply to Martin Renvoize from comment #13)
> I'd be happy with either a different icon or a visible change on the
> background colour.. i.e some striped or zigzags or something.. both would
> satisfy the accessibility requirements.

 I could see people overriding background colour for customizations, so I'm not sure how practical that is. I could also see people complaining about stripes or zigzags, although I like the sound of them.
Comment 16 Fridolin SOMERS 2020-10-20 09:48:48 UTC
(In reply to Owen Leonard from comment #12)
> https://fontawesome.com/v4.7.0/icon/bolt ?

+1 for that, its perfect.

The Flash is a superlibarian XD.

PS :
People are used to "user-secret" as web-browser private navigation.
Comment 17 David Cook 2020-10-21 00:37:00 UTC
(In reply to Fridolin SOMERS from comment #16)
> (In reply to Owen Leonard from comment #12)
> > https://fontawesome.com/v4.7.0/icon/bolt ?
> 
> +1 for that, its perfect.
> 
> The Flash is a superlibarian XD.
> 
> PS :
> People are used to "user-secret" as web-browser private navigation.

I'm also +1 for "bolt" and I agree about "user-secret" being for private navigation.
Comment 18 Fridolin SOMERS 2020-10-21 08:37:15 UTC
Comment on attachment 111875 [details] [review]
Bug 26687: Add color to Font Awesome icon for superlibrarian patrons

I'll create a new patch
Comment 19 Fridolin SOMERS 2020-10-22 07:49:00 UTC
Created attachment 112140 [details]
Screenshot
Comment 20 Fridolin SOMERS 2020-10-22 07:51:36 UTC
Created attachment 112141 [details] [review]
Bug 26687: Add a Font Awesome icon for superlibrarian patrons

Bug 26534 adds a shield Font Awesome icon to help identify staff
patrons. I propose to add an icon when patron is a superlibrarian.

Patch adds 'is-superlibrarian' class that may be used for more CSS
tuning.

Test plan:
1) Compare display between a patron A beeing superlibarian and a patron
   B having only staff interface access
2) Patron B has only shield icon
3) Patron A has shield icon and bolt icon
4) Check a patron without permissions has no shield icon
Comment 21 Séverine Queune 2020-10-23 10:24:02 UTC
Created attachment 112245 [details] [review]
Bug 26687: Add a Font Awesome icon for superlibrarian patrons

Bug 26534 adds a shield Font Awesome icon to help identify staff
patrons. I propose to add an icon when patron is a superlibrarian.

Patch adds 'is-superlibrarian' class that may be used for more CSS
tuning.

Test plan:
1) Compare display between a patron A beeing superlibarian and a patron
   B having only staff interface access
2) Patron B has only shield icon
3) Patron A has shield icon and bolt icon
4) Check a patron without permissions has no shield icon

Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Comment 22 Katrin Fischer 2020-10-23 10:36:26 UTC
Created attachment 112247 [details] [review]
Bug 26687: Add a Font Awesome icon for superlibrarian patrons

Bug 26534 adds a shield Font Awesome icon to help identify staff
patrons. I propose to add an icon when patron is a superlibrarian.

Patch adds 'is-superlibrarian' class that may be used for more CSS
tuning.

Test plan:
1) Compare display between a patron A beeing superlibarian and a patron
   B having only staff interface access
2) Patron B has only shield icon
3) Patron A has shield icon and bolt icon
4) Check a patron without permissions has no shield icon

Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>