There is a link labelled "here" that should be improved on the patron attributes page. To test: - Set ExtendedPatronAttributes system preference to "Don't enable" - Go to Administration > Patron attribute types The "here" link in the blue box at the top of the page should have a more meaningful link text.
Created attachment 112314 [details] [review] bug 26725: changed the text of the "here" link on the patron attributes administration page test plan: 1. set ExtendedPatronAttributes system preferences to "Don't enable" 2. go to Administration > Patron attribute types 3. the link text of "here" is displayed in the blue box at the top of the page 4. apply the patch 5. refresh the page 6. notice the link text has changed to "ExtendedPatronAttributes System Preference"
This all works as per the test plan, but I would: - just link the system preference name - put system preference in sentence case. A nice improvement and gets rid of the 'click here' type links!
Created attachment 112315 [details] [review] bug 26725: link text changed to just system preference name. "system preference" put in sentence case.
Attached patch that fixes your notes in comment #2. Could you please test again?
Created attachment 112319 [details] [review] bug 26725: changed the text of the "here" link on the patron attributes administration page test plan: 1. set ExtendedPatronAttributes system preferences to "Don't enable" 2. go to Administration > Patron attribute types 3. the link text of "here" is displayed in the blue box at the top of the page 4. apply the patch 5. refresh the page 6. notice the link text has changed to "ExtendedPatronAttributes System Preference" Signed-off-by: David Nind <david@davidnind.com>
Created attachment 112320 [details] [review] bug 26725: link text changed to just system preference name. "system preference" put in sentence case. Signed-off-by: David Nind <david@davidnind.com>
Created attachment 112343 [details] [review] Bug 26725: changed the text of the "here" link on the patron attributes administration page test plan: 1. set ExtendedPatronAttributes system preferences to "Don't enable" 2. go to Administration > Patron attribute types 3. the link text of "here" is displayed in the blue box at the top of the page 4. apply the patch 5. refresh the page 6. notice the link text has changed to "ExtendedPatronAttributes System Preference" Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Created attachment 112344 [details] [review] Bug 26725: link text changed to just system preference name. "system preference" put in sentence case. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Created attachment 112345 [details] [review] Bug 26725: (QA follow-up) Add line break and 'the' for readability Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Now Tal has a Bugzilla account, I'll set her as the assignee :)
Pushed to master for 20.11, thanks to everybody involved!
Congratulations Tal for your first patch pushed!
enhancement, not backported to 19.11.x
Lucas has also backported this to 20.05.x for 20.05.06