Bug 26746 - Variables available for selecting into notices are misleading
Summary: Variables available for selecting into notices are misleading
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: Notices (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Martin Renvoize (ashimema)
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks: 15277
  Show dependency tree / graph
 
Reported: 2020-10-20 09:43 UTC by Martin Renvoize (ashimema)
Modified: 2023-12-20 13:54 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Renvoize (ashimema) 2020-10-20 09:43:22 UTC 
The list of variables available to selectively add to a notice can be misleading.  They are currently a list of database field names selected by the module which the notice has been assigned to.. however not all notices actually pass all these tables into GetPreparedLetter and so not all variables are always supported and sometimes additional 'hidden' ones are available.

We should clarify this and add support for TT variables at the same time.

I believe we could/should do this within C4::Letters itself with a configuration block that lists accepted variables (tables, substitutions, loops etc) which can then be used both to construct the lists in the UI and also to check that the calls to GetPreparedLetter are indeed passing in the required/listed variables we list.