When a user is in the Inventory Tool, Select all only selects the first 20 records in the selecting option of the Inventory, even if you change the view to show 50, 100, or all options. The expected behavior is that Select All would select all the options. To recreate this issue, go to Tools-> Inventory-> Do a Search to produce more than 20 results -> Select Add Items. Next, select 50, 100 or All entries to show. Then, click on Select All. Only the first 20 entries are selected, not all of the entries on the screen.
Created attachment 114087 [details] [review] Bug 26983: Fix [un]select all links in inventory The select/unselect all links took into account only the items displayed when the page was loaded (so 20). Test plan: 1. Go to Tools-> Inventory-> Do a Search to produce more than 20 results 2. Select 50, 100 or All entries to show 3. click on Select All => All items must be selected, not only the first 20
Created attachment 114325 [details] [review] Bug 26983: Fix [un]select all links in inventory The select/unselect all links took into account only the items displayed when the page was loaded (so 20). Test plan: 1. Go to Tools-> Inventory-> Do a Search to produce more than 20 results 2. Select 50, 100 or All entries to show 3. click on Select All => All items must be selected, not only the first 20 Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
Ok fix is working. Will testing I see that "Select all" in fact selects the visible lines. Maybe we should rename it "Select visible rows", like in items search.
Created attachment 114951 [details] [review] Bug 26983: Fix [un]select all links in inventory The select/unselect all links took into account only the items displayed when the page was loaded (so 20). Test plan: 1. Go to Tools-> Inventory-> Do a Search to produce more than 20 results 2. Select 50, 100 or All entries to show 3. click on Select All => All items must be selected, not only the first 20 Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Pushed to master for 21.05, thanks to everybody involved!
Any chance this can be backported to 20.05?
Pushed to 20.11.x for 20.11.02
(In reply to Martha Fuerst from comment #6) > Any chance this can be backported to 20.05? Surely Andrew will backport to 20.05.xx
Surely I have done so :) Pushed to 20.05.x for 20.05.08
Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed.