Created attachment 113540 [details] Print screen actions_logs table When a user adds an instance, the information is saved in the action_logs table, however it is evident that in version 20.05 the object column remains empty. This is not the case in previous versions.
Created attachment 114086 [details] [review] Bug 27003: Item creation log must be done after the item is created Otherwise we don't have its itemnumber yet! Test plan: Add and modify an item and confirm that the action logs are created correctly
Created attachment 114093 [details] [review] Bug 27003: Item creation log must be done after the item is created Otherwise we don't have its itemnumber yet! Test plan: Add and modify an item and confirm that the action logs are created correctly Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Small patch, passing QA
Thanks Nick! I'd like a separate QA stamp, just in case. We are going to backport it and it touches a ->store method.
Created attachment 114192 [details] [review] Bug 27003: Item creation log must be done after the item is created Otherwise we don't have its itemnumber yet! Test plan: Add and modify an item and confirm that the action logs are created correctly Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Pushed to master for 20.05, thanks to everybody involved!
Pushed to 20.11.x for 20.11.01
Pushed to master for 21.05, thanks to everybody involved!
Doesn't apply cleanly to 20.05, please rebase if needed
(In reply to Andrew Fuerste-Henry from comment #9) > Doesn't apply cleanly to 20.05, please rebase if needed I am seeing this problem on a 20.05.06.000 installation, so a backport would be much appreciated.
(In reply to Andrew Fuerste-Henry from comment #9) > Doesn't apply cleanly to 20.05, please rebase if needed You will need bug 26470 first.
(In reply to Jonathan Druart from comment #11) > (In reply to Andrew Fuerste-Henry from comment #9) > > Doesn't apply cleanly to 20.05, please rebase if needed > > You will need bug 26470 first. And IMO that's too much conflicts in a critical area.
(In reply to Jonathan Druart from comment #12) > (In reply to Jonathan Druart from comment #11) > > (In reply to Andrew Fuerste-Henry from comment #9) > > > Doesn't apply cleanly to 20.05, please rebase if needed > > > > You will need bug 26470 first. > > And IMO that's too much conflicts in a critical area. So, do we leave the problem unfixed, or could we write a separate patch just for the 20.05 branch?
Created attachment 115438 [details] [review] Bug 27003: [20.05.x] Item creation log must be done after the item is created Otherwise we don't have its itemnumber yet! Test plan: Add and modify an item and confirm that the action logs are created correctly
Please try this patch on 20.05.x
Created attachment 115512 [details] [review] Bug 27003: [20.05.x] Item creation log must be done after the item is created Otherwise we don't have its itemnumber yet! Test plan: Add and modify an item and confirm that the action logs are created correctly Signed-off-by: Magnus Enger <magnus@libriotech.no> Applied the patch on a live server showing missing info in the logs. Created and deleted an item. Verified the logs now have the same info as in the olden days.
PS. The live server was running 20.05.06.
New patch pushed to 20.05.x for 20.05.08. thanks!
Created attachment 115712 [details] [review] Bug 27003: [20.05.x] Fix test failure
Missing dependencies for 19.11.x, shouldn't be affected, no backport.
Follow-up pushed to 20.05.x for 20.05.08