Bug 27003 - action_logs table error when adding an item
Summary: action_logs table error when adding an item
Status: Pushed to stable
Alias: None
Product: Koha
Classification: Unclassified
Component: Database (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low major (vote)
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords:
Depends on: 23463
Blocks:
  Show dependency treegraph
 
Reported: 2020-11-12 01:34 UTC by Andres Ovalle López
Modified: 2020-12-15 20:30 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Text to go in the release notes:
Version(s) released in:
21.05.00,20.11.01


Attachments
Print screen actions_logs table (53.35 KB, image/png)
2020-11-12 01:34 UTC, Andres Ovalle López
Details
Bug 27003: Item creation log must be done after the item is created (4.33 KB, patch)
2020-12-02 08:57 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 27003: Item creation log must be done after the item is created (4.39 KB, patch)
2020-12-02 10:50 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 27003: Item creation log must be done after the item is created (4.44 KB, patch)
2020-12-04 13:16 UTC, Julian Maurice
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Andres Ovalle López 2020-11-12 01:34:38 UTC
Created attachment 113540 [details]
Print screen actions_logs table

When a user adds an instance, the information is saved in the action_logs table, however it is evident that in version 20.05 the object column remains empty. This is not the case in previous versions.
Comment 1 Jonathan Druart 2020-12-02 08:57:12 UTC
Created attachment 114086 [details] [review]
Bug 27003: Item creation log must be done after the item is created

Otherwise we don't have its itemnumber yet!

Test plan:
Add and modify an item and confirm that the action logs are created
correctly
Comment 2 Nick Clemens 2020-12-02 10:50:04 UTC
Created attachment 114093 [details] [review]
Bug 27003: Item creation log must be done after the item is created

Otherwise we don't have its itemnumber yet!

Test plan:
Add and modify an item and confirm that the action logs are created
correctly

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 3 Nick Clemens 2020-12-02 10:50:20 UTC
Small patch, passing QA
Comment 4 Jonathan Druart 2020-12-02 11:00:47 UTC
Thanks Nick!

I'd like a separate QA stamp, just in case. We are going to backport it and it touches a ->store method.
Comment 5 Julian Maurice 2020-12-04 13:16:58 UTC
Created attachment 114192 [details] [review]
Bug 27003: Item creation log must be done after the item is created

Otherwise we don't have its itemnumber yet!

Test plan:
Add and modify an item and confirm that the action logs are created
correctly

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Comment 6 Jonathan Druart 2020-12-04 16:04:56 UTC Comment hidden (obsolete)
Comment 7 Fridolin Somers 2020-12-07 08:06:33 UTC
Pushed to 20.11.x for 20.11.01
Comment 8 Jonathan Druart 2020-12-07 16:53:51 UTC
Pushed to master for 21.05, thanks to everybody involved!
Comment 9 Andrew Fuerste-Henry 2020-12-15 20:30:45 UTC
Doesn't apply cleanly to 20.05, please rebase if needed