Bug 27051 - opac-library.tt should include email
Summary: opac-library.tt should include email
Status: CLOSED WONTFIX
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Lucas Gass
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-11-18 14:35 UTC by Lucas Gass
Modified: 2023-06-08 22:26 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 26986: Prevent Selenium's StaleElementReferenceException (2.30 KB, patch)
2020-11-18 14:49 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 27051: Add email to OPAC library page (1.35 KB, patch)
2020-11-18 14:55 UTC, Lucas Gass
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Gass 2020-11-18 14:35:39 UTC
opac-library.tt omits the branch email address. This information would be nice to show on the page as a 'mailto:' link.
Comment 1 Lucas Gass 2020-11-18 14:49:54 UTC
Created attachment 113787 [details] [review]
Bug 26986: Prevent Selenium's StaleElementReferenceException

Test plan:
1. Add some branch emails via /cgi-bin/koha/admin/branches.pl
2. Go to the OPAC and opac-library.pl, notice there emails are not listed
3. Apply patch
4. Reloda opac-library.pl and you should see the branch email addresses.

This is a follow-up bug for bug 26162

By finding the element before the click I hope to get the good element,
even if the page changed in the meanwhile.

Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 2 Lucas Gass 2020-11-18 14:55:54 UTC
Created attachment 113788 [details] [review]
Bug 27051: Add email to OPAC library page

Test plan:
1. Add some branch emails via /cgi-bin/koha/admin/branches.pl
2. Go to the OPAC and opac-library.pl, notice there emails are not listed
3. Apply patch
4. Reloda opac-library.pl and you should see the branch email addresses.
Comment 3 Katrin Fischer 2020-11-18 22:08:54 UTC
We deliberately left the email off because email configuration can differ. I'd have to remove this from every of our 130 installations because for us the reply to contains the email to the library due to spam restrictions with the mail servers.

Also: no spam protection if you put the email on the page directly.

Could we imagine making this one a multi-select pref maybe?
Comment 4 Lucas Gass 2020-11-20 16:49:53 UTC
(In reply to Katrin Fischer from comment #3)
> We deliberately left the email off because email configuration can differ.
> I'd have to remove this from every of our 130 installations because for us
> the reply to contains the email to the library due to spam restrictions with
> the mail servers.
> 
> Also: no spam protection if you put the email on the page directly.
> 
> Could we imagine making this one a multi-select pref maybe?

Cait, that makes perfect sense. 

For my clarity: You are proposing a system pref that where users can choose which fields display on the library page? 

Or would it be better to add an option on branches.tt where users could add an 'OPAC display email' which could differ from the branch email?


Thanks for looking at this.
Comment 5 Katrin Fischer 2020-11-20 23:40:27 UTC
I kinda like the multi-select a little more because I feel like it might be more multi-purpose ... but not sure how we could go about the spam issue and if we should?