opac-library.tt omits the branch email address. This information would be nice to show on the page as a 'mailto:' link.
Created attachment 113787 [details] [review] Bug 26986: Prevent Selenium's StaleElementReferenceException Test plan: 1. Add some branch emails via /cgi-bin/koha/admin/branches.pl 2. Go to the OPAC and opac-library.pl, notice there emails are not listed 3. Apply patch 4. Reloda opac-library.pl and you should see the branch email addresses. This is a follow-up bug for bug 26162 By finding the element before the click I hope to get the good element, even if the page changed in the meanwhile. Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 113788 [details] [review] Bug 27051: Add email to OPAC library page Test plan: 1. Add some branch emails via /cgi-bin/koha/admin/branches.pl 2. Go to the OPAC and opac-library.pl, notice there emails are not listed 3. Apply patch 4. Reloda opac-library.pl and you should see the branch email addresses.
We deliberately left the email off because email configuration can differ. I'd have to remove this from every of our 130 installations because for us the reply to contains the email to the library due to spam restrictions with the mail servers. Also: no spam protection if you put the email on the page directly. Could we imagine making this one a multi-select pref maybe?
(In reply to Katrin Fischer from comment #3) > We deliberately left the email off because email configuration can differ. > I'd have to remove this from every of our 130 installations because for us > the reply to contains the email to the library due to spam restrictions with > the mail servers. > > Also: no spam protection if you put the email on the page directly. > > Could we imagine making this one a multi-select pref maybe? Cait, that makes perfect sense. For my clarity: You are proposing a system pref that where users can choose which fields display on the library page? Or would it be better to add an option on branches.tt where users could add an 'OPAC display email' which could differ from the branch email? Thanks for looking at this.
I kinda like the multi-select a little more because I feel like it might be more multi-purpose ... but not sure how we could go about the spam issue and if we should?