Bug 27073 - refactor cover image to get image(s) (url) from api call/template include
Summary: refactor cover image to get image(s) (url) from api call/template include
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-11-20 20:48 UTC by Mark Hofstetter
Modified: 2020-12-21 11:57 UTC (History)
0 users

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Hofstetter 2020-11-20 20:48:00 UTC
it seems for me that there is (template) code duplication to show cover images.
see 
grep -rl OPACAmazonCoverImages
includes/shelfbrowser.inc
includes/opac-bottom.inc
modules/opac-user.tt
modules/opac-opensearch.tt
modules/opac-results-grouped.tt
modules/opac-readingrecord.tt
modules/opac-detail.tt
modules/opac-shelves.tt
modules/opac-showreviews-rss.tt
modules/opac-showreviews.tt
modules/opac-results.tt

I'm not sure if this is autogenerated?

maybe this duplicate code should be wrapped in an api call, with more logic implemented than in the rather crude template if-statments