Koha plugins hook 'intranet_catalog_biblio_tab' should have the datas of the current biblio record. Koha::Biblio is aleady in template, send it with hooks call. Depends on Bug 27114
Created attachment 114061 [details] Sample plugin Sample plugin for test plan
Created attachment 114062 [details] [review] Bug 27120: Send biblio to Koha plugins hook 'intranet_catalog_biblio_tab' Koha plugins hook 'intranet_catalog_biblio_tab' should have the datas of the current biblio record. Koha::Biblio is aleady in template, send it with hooks call. This will be very usefull to be able to fetch external datas (wikipedia, youtube, ...) depending on current biblio record. Test plan : 1) Enable Koha plugins 2) Install plugin attached to this bug 3) Go to staff interface on a biblio record details page 4) Check you see tab 1 containing 'Tab for record {title}' 5) Check you see tab 2 containing 'Tab for record {isbn}'
Looks great.. sorry Fridolin.. sha1 issue on apply though.
Created attachment 118085 [details] [review] Bug 27120: Send biblio to Koha plugins hook 'intranet_catalog_biblio_tab' Koha plugins hook 'intranet_catalog_biblio_tab' should have the datas of the current biblio record. Koha::Biblio is aleady in template, send it with hooks call. This will be very usefull to be able to fetch external datas (wikipedia, youtube, ...) depending on current biblio record. Test plan : 1) Enable Koha plugins 2) Install plugin attached to this bug 3) Go to staff interface on a biblio record details page 4) Check you see tab 1 containing 'Tab for record {title}' 5) Check you see tab 2 containing 'Tab for record {isbn}'
Created attachment 118086 [details] [review] Bug 27120: (follow-up) also send biblionumber Like in after_biblio_action hook
Created attachment 119096 [details] [review] Bug 27120: Send biblio to Koha plugins hook 'intranet_catalog_biblio_tab' Koha plugins hook 'intranet_catalog_biblio_tab' should have the datas of the current biblio record. Koha::Biblio is aleady in template, send it with hooks call. This will be very usefull to be able to fetch external datas (wikipedia, youtube, ...) depending on current biblio record. Test plan : 1) Enable Koha plugins 2) Install plugin attached to this bug 3) Go to staff interface on a biblio record details page 4) Check you see tab 1 containing 'Tab for record {title}' 5) Check you see tab 2 containing 'Tab for record {isbn}' Signed-off-by: David Nind <david@davidnind.com>
Created attachment 119098 [details] [review] Bug 27120: (follow-up) also send biblionumber Like in after_biblio_action hook Signed-off-by: David Nind <david@davidnind.com>
Note: For steps 4 and 5 the new tabs contain "This is content for tab 1" and "This is content for tab 2". Have signed-off on the basis that this is what was expected.
Created attachment 119734 [details] [review] Bug 27120: Send biblio to Koha plugins hook 'intranet_catalog_biblio_tab' Koha plugins hook 'intranet_catalog_biblio_tab' should have the datas of the current biblio record. Koha::Biblio is aleady in template, send it with hooks call. This will be very usefull to be able to fetch external datas (wikipedia, youtube, ...) depending on current biblio record. Test plan : 1) Enable Koha plugins 2) Install plugin attached to this bug 3) Go to staff interface on a biblio record details page 4) Check you see tab 1 containing 'Tab for record {title}' 5) Check you see tab 2 containing 'Tab for record {isbn}' Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 119735 [details] [review] Bug 27120: (follow-up) also send biblionumber Like in after_biblio_action hook Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Pushed to master for 21.05, thanks to everybody involved!
Pushed to 20.11.x for 20.11.06
Note: it was pushed to 20.05.x for 20.05.12
Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed.