Bug 27269 - Move C4::Biblio::GetMarcSubjects to Koha namespace
Summary: Move C4::Biblio::GetMarcSubjects to Koha namespace
Status: Failed QA
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Aleisha Amohia
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-12-18 02:14 UTC by Aleisha Amohia
Modified: 2024-01-10 16:49 UTC (History)
3 users (show)

See Also:
Change sponsored?: Sponsored
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 27269: Move GetMarcSubjects to Koha namespace (16.56 KB, patch)
2020-12-18 02:49 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 27269: Move GetMarcSubjects to Koha namespace (16.09 KB, patch)
2023-02-13 02:01 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 27269: Move GetMarcSubjects to Koha namespace (18.59 KB, patch)
2023-05-29 01:38 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 27269: Move GetMarcSubjects to Koha namespace (18.61 KB, patch)
2023-05-30 11:46 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 27269: Move GetMarcSubjects to Koha namespace (19.00 KB, patch)
2023-11-17 00:14 UTC, Aleisha Amohia
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Aleisha Amohia 2020-12-18 02:14:10 UTC

    
Comment 1 Aleisha Amohia 2020-12-18 02:49:50 UTC
Created attachment 114505 [details] [review]
Bug 27269: Move GetMarcSubjects to Koha namespace

This patch moves C4::Biblio::GetMarcSubjects to
Koha::Biblio->get_marc_subjects. This is so get_marc_subjects can be
used in templates and notices.

To test:
1. Find a record that has a subject (6xx).
2. Add the record to the cart and a list.
3. View your cart and click 'more details'. Confirm subjects show as
normal.
4. Click 'send' and confirm the email sent shows the subjects as normal.
5. Go to the list you added the record to and click 'send list'. Confirm
the email sent shows the ubjectsas normal.
6. Set the OPACXSLTDetailsDisplay system preference to empty (for no xslt)
7. Log in to the OPAC. Find the record and add it to the cart and a list
8. View the cart and click 'more details'. Confirm subjects show as
normal.
9. Click 'send' and confirm the email sent shows the subjects as normal.
10. Go to the list you added the record to and click 'send list'.
Confirm the email sent shows the subjects as normal.
11. View the record detail page and confirm the subjects show as normal.
12. Confirm tests pass:
- t/Biblio.t
- t/db_dependent/Koha/Biblio.t

Sponsored-by: Bibliotheksservice-Zentrum Baden-Württemberg (BSZ)
Comment 2 Joonas Kylmälä 2021-11-13 14:46:47 UTC
Doesn't apply anymore :(
Comment 3 Aleisha Amohia 2023-02-13 02:01:13 UTC Comment hidden (obsolete)
Comment 4 Owen Leonard 2023-05-26 12:44:27 UTC
Sorry this needs to be rebased again
Comment 5 Aleisha Amohia 2023-05-29 01:38:02 UTC Comment hidden (obsolete)
Comment 6 Owen Leonard 2023-05-30 11:46:44 UTC
Created attachment 151793 [details] [review]
Bug 27269: Move GetMarcSubjects to Koha namespace

This patch moves C4::Biblio::GetMarcSubjects to
Koha::Biblio->get_marc_subjects. This is so get_marc_subjects can be
used in templates and notices.

To test:
1. Find a record that has a subject (6xx).
2. Add the record to the cart and a list.
3. View your cart and click 'more details'. Confirm subjects show as
normal.
4. Click 'send' and confirm the email sent shows the subjects as normal.
5. Go to the list you added the record to and click 'send list'. Confirm
the email sent shows the ubjectsas normal.
6. Set the OPACXSLTDetailsDisplay system preference to empty (for no xslt)
7. Log in to the OPAC. Find the record and add it to the cart and a list
8. View the cart and click 'more details'. Confirm subjects show as
normal.
9. Click 'send' and confirm the email sent shows the subjects as normal.
10. Go to the list you added the record to and click 'send list'.
Confirm the email sent shows the subjects as normal.
11. View the record detail page and confirm the subjects show as normal.
12. Confirm tests pass:
- t/Biblio.t
- t/db_dependent/Koha/Biblio.t

Sponsored-by: Bibliotheksservice-Zentrum Baden-Württemberg (BSZ)
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 7 Owen Leonard 2023-05-30 11:48:37 UTC
> 4. Click 'send' and confirm the email sent shows the subjects as normal.

None of the emails sent according to the test plan include subject information, but that is true in master too.
Comment 8 Aleisha Amohia 2023-11-17 00:14:51 UTC
Created attachment 159069 [details] [review]
Bug 27269: Move GetMarcSubjects to Koha namespace

This patch moves C4::Biblio::GetMarcSubjects to
Koha::Biblio->get_marc_subjects. This is so get_marc_subjects can be
used in templates and notices.

To test:
1. Find a record that has a subject (6xx).
2. Add the record to the cart and a list.
3. View your cart and click 'more details'. Confirm subjects show as
normal.
4. Click 'send' and confirm the email sent shows the subjects as normal.
5. Go to the list you added the record to and click 'send list'. Confirm
the email sent shows the ubjectsas normal.
6. Set the OPACXSLTDetailsDisplay system preference to empty (for no xslt)
7. Log in to the OPAC. Find the record and add it to the cart and a list
8. View the cart and click 'more details'. Confirm subjects show as
normal.
9. Click 'send' and confirm the email sent shows the subjects as normal.
10. Go to the list you added the record to and click 'send list'.
Confirm the email sent shows the subjects as normal.
11. View the record detail page and confirm the subjects show as normal.
12. Confirm tests pass:
- t/Biblio.t
- t/db_dependent/Koha/Biblio.t

Sponsored-by: Bibliotheksservice-Zentrum Baden-Württemberg (BSZ)
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 9 Phan Tung Bui 2024-01-10 16:13:15 UTC
So here how i do the test

- Apply the patch
- Add a record which contains 2-3 subjects into the cart
- Send it to a random selected Email
- Go to the database and find the email in message_queue
- Absence of subject in the email
Comment 10 Phan Tung Bui 2024-01-10 16:49:25 UTC
phan