Currently, Circulation note (borrowers.borrowernotes) and item notes (items.itemnotes and items.itemnotes_nonpublic) are displayed during check-in. This patch adds Opac note (borrowers.opacnote) and Opac messages (messages table). Test plan: - Add an Opac note and one or several Opac messages to a patron. - Checkout and check-in an item for this patron. - Check that Opac note and Opac message(s) are not displayed on check-in. - Apply the patch. - Checkout and check-in an item for this patron. - Check that Opac note and Opac message(s) are displayed on check-in.
Created attachment 114856 [details] [review] Bug 27339: Display opac notes and opac messages on check-in . Adds Opac note (borrowers.opacnote) and Opac messages (messages table) during check-in. Test plan: 1- Add an Opac note and one or several Opac messages to a patron. 2- Checkout and check-in an item for this patron. 3- Check that Opac note and Opac message(s) are not displayed on check-in. 4- Apply the patch. 5- Checkout and check-in an item for this patron. 6- Check that Opac note and Opac message(s) are displayed on check-in.
Hi Didier, I'm just curious why we display the OPAC message but not the staff internal - message here?
Created attachment 116144 [details] [review] Bug 27339: Display opac notes and opac messages on check-in . Adds Opac note (borrowers.opacnote) and Opac messages (messages table) during check-in. Test plan: 1- Add an Opac note and one or several Opac messages to a patron. 2- Checkout and check-in an item for this patron. 3- Check that Opac note and Opac message(s) are not displayed on check-in. 4- Apply the patch. 5- Checkout and check-in an item for this patron. 6- Check that Opac note and Opac message(s) are displayed on check-in. Signed-off-by: Stina Hallin <stina.hallin@ub.lu.se>
Hi Didier, I can see that you were active on the patch, but the given author is Author: Matthias Meusburger <matthias.meusburger@biblibre.com>. Is this correct?
I like that you have given each note an individual class, that would make it possible to hide things for libraries as these notes could get a bit much for some depending on their use. Now one note is still missing: The staff message. I think these might often be used to give some kind of history about the patron so could really turn into too much information here. I assume libraries are more likely to remove OPAC messages, that are no longer needed. So I am ok with that.
I have been looking at this a bit longer... and I'd suggest to create a new column for the OPAC notes in the table and add it to the column configuration. With the current solution we cannot see the context of the notes, I think this would make things clearer. What do you think?
I think your suggestion is good. You might end up with too many notes in one column, and some of them might not be important in the checkin workflow. Best if the coulmn only is visible if there are any notes to display.
Created attachment 170069 [details] [review] Bug 27339: Display opac notes and opac messages on check-in . Adds Opac note (borrowers.opacnote) and Opac messages (messages table) during check-in. Test plan: 1- Add an Opac note and one or several Opac messages to a patron. 2- Checkout and check-in an item for this patron. 3- Check that Opac note and Opac message(s) are not displayed on check-in. 4- Apply the patch. 5- Checkout and check-in an item for this patron. 6- Check that Opac note and Opac message(s) are displayed on check-in. Signed-off-by: Stina Hallin <stina.hallin@ub.lu.se>
Created attachment 170070 [details] [review] Bug 27339: Display opac notes and opac messages on check-in Adds Opac note (borrowers.opacnote) and Opac messages (messages table) during check-in. Test plan: 1- Add an Opac note and one or several Opac messages to a patron. 2- Checkout and check-in an item for this patron. 3- Check that Opac note and Opac message(s) are not displayed on check-in. 4- Apply the patch. 5- Checkout and check-in an item for this patron. 7- Check that Opac note and Opac message(s) are displayed on check-in in two columns.
Created attachment 170071 [details] [review] Bug 27339: (follow-up) Display opac notes and opac messages on check-in Adds Opac note (borrowers.opacnote) and Opac messages (messages table) during check-in. Test plan: 1- Add an Opac note and one or several Opac messages to a patron. 2- Checkout and check-in an item for this patron. 3- Check that Opac note and Opac message(s) are not displayed on check-in. 4- Apply the patch. 5- Checkout and check-in an item for this patron. 7- Check that Opac note and Opac message(s) are displayed on check-in in two columns.
We need the new table field adding to the table configurations I'm afraid.
Created attachment 176012 [details] [review] Bug 27339: (follow-up) Display opac notes and opac messages on check-in Adds Opac note (borrowers.opacnote) and Opac messages (messages table) during check-in. Test plan: 1- Add an Opac note and one or several Opac messages to a patron. 2- Checkout and check-in an item for this patron. 3- Check that Opac note and Opac message(s) are not displayed on check-in. 4- Apply the patch. 5- Checkout and check-in an item for this patron. 7- Check that Opac note and Opac message(s) are displayed on check-in in two columns.
Baptiste - Thank you for working on this patch! It looks like the OPAC note is showing under notes in the check in table, instead of OPAC notes.
Created attachment 176072 [details] [review] Bug 27339: (follow-up) Display opac notes and opac messages on check-in Adds Opac note (borrowers.opacnote) and Opac messages (messages table) during check-in. Test plan: 1- Add an Opac note and one or several Opac messages to a patron. 2- Checkout and check-in an item for this patron. 3- Check that Opac note and Opac message(s) are not displayed on check-in. 4- Apply the patch. 5- Checkout and check-in an item for this patron. 7- Check that Opac note and Opac message(s) are displayed on check-in in two columns.
I also added the opac messages in the column OPAC Notes :)
Created attachment 176094 [details] [review] Bug 27339: Display opac notes and opac messages on check-in . Adds Opac note (borrowers.opacnote) and Opac messages (messages table) during check-in. Test plan: 1- Add an Opac note and one or several Opac messages to a patron. 2- Checkout and check-in an item for this patron. 3- Check that Opac note and Opac message(s) are not displayed on check-in. 4- Apply the patch. 5- Checkout and check-in an item for this patron. 6- Check that Opac note and Opac message(s) are displayed on check-in. Signed-off-by: Stina Hallin <stina.hallin@ub.lu.se> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 176095 [details] [review] Bug 27339: (follow-up) Display opac notes and opac messages on check-in Adds Opac note (borrowers.opacnote) and Opac messages (messages table) during check-in. Test plan: 1- Add an Opac note and one or several Opac messages to a patron. 2- Checkout and check-in an item for this patron. 3- Check that Opac note and Opac message(s) are not displayed on check-in. 4- Apply the patch. 5- Checkout and check-in an item for this patron. 7- Check that Opac note and Opac message(s) are displayed on check-in in two columns. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>