Bug 27363 - Restore temporary selection of Z39.50 targets throughout multiple searches
Summary: Restore temporary selection of Z39.50 targets throughout multiple searches
Status: In Discussion
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Nick Clemens
QA Contact: Testopia
URL:
Keywords: regression
Depends on: 17515
Blocks:
  Show dependency treegraph
 
Reported: 2021-01-07 17:33 UTC by Barbara Johnson
Modified: 2021-08-18 23:06 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 27363: (bug 17515 follow-up) Restore temporary selection of Z39.50 targets throughout multiple searches (2.48 KB, patch)
2021-01-20 14:40 UTC, Jonathan Druart
Details | Diff | Splinter Review
MARC bib record from Advanced Cataloging Editor (62.14 KB, image/png)
2021-01-20 15:46 UTC, Barbara Johnson
Details
Z39.50 results showing preselected servers (85.31 KB, image/png)
2021-01-20 15:46 UTC, Barbara Johnson
Details
Z39.50 results showing new server checked (88.73 KB, image/png)
2021-01-20 15:47 UTC, Barbara Johnson
Details
New Z39.50 search showing added server did not get retained (80.60 KB, image/png)
2021-01-20 15:49 UTC, Barbara Johnson
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Barbara Johnson 2021-01-07 17:33:27 UTC
Prior to 20.05.06, when using Z39.50 in the Advanced Cataloging Editor, servers that were selected each time a new Z39.50 search was done would be retained throughout multiple searches.  This is no longer the case.  

It would be helpful if that behavior was restored.  We have preselected servers which persist for all searches.  As we catalog we add some additional servers that would be retained for a short period of time until we decided we no longer needed them. For instance, we may be cataloging Spanish and we could check a server that could be used for several bibs but it wasn't a server that we 
wanted to be a preselected server.  

Now that a newly checked server is not retained in the short term we have to check it again for every search which is much less efficient.  We could go into Admin and make it a preselected search for the short duration we plan to use it and then go back into Admin to uncheck it when done but that is also not efficient.  

It would be so much more efficient to be able to check a new server, have it retained, and then uncheck it when done.
Comment 1 Katrin Fischer 2021-01-16 20:18:16 UTC
Hi Barbara, as you said this worked before I have updated this to be a bug in stead of an enhancement.
Comment 2 Jonathan Druart 2021-01-20 10:34:41 UTC
"Prior to 20.05.06"
=> Was it working on 20.05.05?
Comment 3 Barbara Johnson 2021-01-20 12:59:12 UTC
Yes, it worked on 20.05.05.
Comment 4 Jonathan Druart 2021-01-20 14:37:45 UTC
May be caused by

  commit 17571f824d391989247465c7ae18c92c744464c2
  Bug 17515: Order Z3950 server by rank and preserve ordering
Comment 5 Jonathan Druart 2021-01-20 14:40:03 UTC
Created attachment 115437 [details] [review]
Bug 27363: (bug 17515 follow-up) Restore temporary selection of Z39.50 targets throughout multiple searches

Not sure it will fix the problem (not sure I recreated the problem
correctly).
So this patch is just a guess, it seems that
  commit 17571f824d391989247465c7ae18c92c744464c2
  Bug 17515: Order Z3950 server by rank and preserve ordering
forgot to update two occurrences of server.name with server.servername
Comment 6 Nick Clemens 2021-01-20 14:51:24 UTC
Hi Barbara,

I am not sure I can recreate the problem, can you provide step by step instructions or screenshots to highlight the issue?

Thanks,
Nick
Comment 7 Jonathan Druart 2021-01-20 15:05:24 UTC
The patch I attached is wrong.
Comment 8 Barbara Johnson 2021-01-20 15:44:01 UTC
To reproduce the problem:

1. Go to the Advanced Cataloging Editor (addbooks.pl)
2. Search for a bib record
3. Select and open a bib record from your own library collection 
4. Copy the ISBN or enter title, author, keyword, etc. in the Search box on the left side of the screen to perform a Z39.50 search (bib.png)
5. View the Z39.50 results – notice a few servers at the top of the list are checked because they are defined as preselected servers (preselected.png)
6. None of the results from the preselected servers have the desired MARC record.
7. Select a new server from the list (such as Dallas) (new_server.png)
8. Select any of the records and click on the Substitute button to import it into Koha.  
9. Edit the bib and save.
10. Edit/add the item record and save.
11. From additem.pl search for the next title to catalog by entering it in the search box at the top of the screen. 
12. Repeat steps 3-5.
13. View the results of the Z39.50 search – notice that the server for Dallas is no longer checked – it does not get retained from search to search like it used to. (server_no_longer_checked.png)
Comment 9 Barbara Johnson 2021-01-20 15:46:13 UTC
Created attachment 115439 [details]
MARC bib record from Advanced Cataloging Editor
Comment 10 Barbara Johnson 2021-01-20 15:46:55 UTC
Created attachment 115440 [details]
Z39.50 results showing preselected servers
Comment 11 Barbara Johnson 2021-01-20 15:47:34 UTC
Created attachment 115441 [details]
Z39.50 results showing new server checked
Comment 12 Barbara Johnson 2021-01-20 15:49:29 UTC
Created attachment 115442 [details]
New Z39.50 search showing added server did not get retained
Comment 13 Barbara Johnson 2021-03-18 16:13:44 UTC
Just checking in on the status of this bug.  We're really missing the old behavior because it is negatively affecting our cataloging efficiency.
Comment 14 Jonathan Druart 2021-03-23 10:26:53 UTC
Nick, can you have a look at this one please?