Bug 27481 - Use Modern::Perl in cataloguing unimarc plugins
Summary: Use Modern::Perl in cataloguing unimarc plugins
Status: Failed QA
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Catherine
QA Contact: Testopia
URL:
Keywords: Academy
Depends on:
Blocks: 2505
  Show dependency treegraph
 
Reported: 2021-01-20 02:38 UTC by Aleisha Amohia
Modified: 2021-12-15 08:06 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 27481:Use 'Modern::Perl' in cataloguing unimarc plugins (4.24 KB, patch)
2021-01-20 03:49 UTC, Catherine
Details | Diff | Splinter Review
Bug 27481:Use 'Modern::Perl' in cataloguing unimarc plugins (4.07 KB, patch)
2021-01-20 20:37 UTC, Catherine
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Aleisha Amohia 2021-01-20 02:38:03 UTC
use Modern::Perl in the place of use strict; use warnings;

cataloguing/value_builder/unimarc_field_105.pl
cataloguing/value_builder/unimarc_field_110.pl
cataloguing/value_builder/unimarc_field_120.pl
cataloguing/value_builder/unimarc_field_130.pl
cataloguing/value_builder/unimarc_field_140.pl
cataloguing/value_builder/unimarc_field_225a.pl
cataloguing/value_builder/unimarc_field_4XX.pl
Comment 1 Catherine 2021-01-20 03:49:41 UTC
Created attachment 115410 [details] [review]
Bug 27481:Use 'Modern::Perl' in cataloguing unimarc plugins

Test plan:
Check Modern::Perl is used in the place of use strict; use warnings;

Sponsored by Catalyst IT
Comment 2 Catherine 2021-01-20 03:56:33 UTC
Hi, I am still working on this. Please don't test.
Comment 3 Catherine 2021-01-20 20:37:39 UTC
Created attachment 115456 [details] [review]
Bug 27481:Use 'Modern::Perl' in cataloguing unimarc plugins

In this bug Modern::Perl was not used because #use warnings; was a
comment so Modern:: Perl did not apply

Test plan:
1. Add patch
2. Check use strict; is used in the files below
cataloguing/value_builder/unimarc_field_105.pl
cataloguing/value_builder/unimarc_field_110.pl
cataloguing/value_builder/unimarc_field_120.pl
cataloguing/value_builder/unimarc_field_130.pl
cataloguing/value_builder/unimarc_field_140.pl
cataloguing/value_builder/unimarc_field_225a.pl
cataloguing/value_builder/unimarc_field_4XX.pl

Sponsored by Catalyst IT
Comment 4 Jonathan Druart 2021-12-15 08:06:06 UTC
This patch is not doing what it is advertising. We should use Modern::Perl, not removing a line that is commented-out.