use Modern::Perl in the place of use strict; use warnings; cataloguing/value_builder/unimarc_field_105.pl cataloguing/value_builder/unimarc_field_110.pl cataloguing/value_builder/unimarc_field_120.pl cataloguing/value_builder/unimarc_field_130.pl cataloguing/value_builder/unimarc_field_140.pl cataloguing/value_builder/unimarc_field_225a.pl cataloguing/value_builder/unimarc_field_4XX.pl
Created attachment 115410 [details] [review] Bug 27481:Use 'Modern::Perl' in cataloguing unimarc plugins Test plan: Check Modern::Perl is used in the place of use strict; use warnings; Sponsored by Catalyst IT
Hi, I am still working on this. Please don't test.
Created attachment 115456 [details] [review] Bug 27481:Use 'Modern::Perl' in cataloguing unimarc plugins In this bug Modern::Perl was not used because #use warnings; was a comment so Modern:: Perl did not apply Test plan: 1. Add patch 2. Check use strict; is used in the files below cataloguing/value_builder/unimarc_field_105.pl cataloguing/value_builder/unimarc_field_110.pl cataloguing/value_builder/unimarc_field_120.pl cataloguing/value_builder/unimarc_field_130.pl cataloguing/value_builder/unimarc_field_140.pl cataloguing/value_builder/unimarc_field_225a.pl cataloguing/value_builder/unimarc_field_4XX.pl Sponsored by Catalyst IT
This patch is not doing what it is advertising. We should use Modern::Perl, not removing a line that is commented-out.