This is something I came across when translating Koha. Some system preferences use Display/Don't display as their choices and others use Show/Don't show. I propose to normalize the terms, i.e. choose one and stick with it (with the amount in each, I would choose to keep Show/Don't show). Show/Don't show - AdlibrisCoversEnabled - AmazonCoverImages - DisplayClearScreenButton - displayFacetCount - DisplayOPACiconsXSLT - EnhancedMessagingPreferencesOPAC - ExportCircHistory - FRBRizeEditions - hidelostitems - HidePatronName - intranetbookbag - IntranetCatalogSearchPulldown - LibraryThingForLibrariesEnabled - numSearchResultsDropdown - OPACAmazonCoverImages - OpacCloud - OPACItemsResultsDisplay - OpacKohaUrl - OPACnumSearchResultsDropdown - OPACpatronimages - OPACShowCheckoutName - OPACShowMusicalInscripts - OpacShowRecentComments - OpacSuggestionManagedBy - OPACFRBRizeEditions - OpacMaintenance - OPACUserSummary - OpenLibrarySearch - OPACShelfBrowser - OPACShowUnusedAuthorities - OPACViewOthersSuggestions - SelfCheckReceiptPrompt - ShowAllCheckins - showLastPatron - ShowPatronImageInWebBasedSelfCheck - SyndeticsAuthorNotes - SyndeticsAwards - SyndeticsCoverImages - SyndeticsEditions - SyndeticsExcerpt - SyndeticsReviews - SyndeticsSeries - SyndeticsSummary - SyndeticsTOC - UseWYSIWYGinSystemPreferences Display/Don't display - AcquisitionDetails - advancedMARCeditor - AuthDisplayHierarchy - BiblioItemtypeInfo - CustomCoverImages - EasyAnalyticalRecords - hide_marc - LocalCoverImages - OPACAcquisitionDetails - OPACCustomCoverImages - OPACLocalCoverImages - OpacNewsLibrarySelect - OPACPopupAuthorsSearch - SpineLabelShowPrintOnBibDetails While we're at it, I would also change the following : - noItemTypeImages: Yes/No - OpacNoItemTypeImages: Yes/No - ShowReviewerPhoto: Show/Hide - PatronSelfRegistrationPrefillForm: display and prefill/don't display and prefill
No comment? We'll use display/not display accross the board.
Created attachment 135144 [details] [review] Bug 27519: Normalize Show/Don't show in system preferences Replace Display/Don't display by Show/Don't show in system preferences. Test plan: 1- Go to administration > system preferences 2- View any system preference with Display/Don't display pair of options (e.g. OPACAcquisitionDetails) 3- Apply the patch 4- Refresh the page and notice it is now a Show/Don't show pair instead 5- Loop the steps with other system preferences until satisfied
Created attachment 135145 [details] [review] Bug 27519: Normalize Show/Don't show in system preferences Replace Display/Don't display (and some other pairs) by Show/Don't show in system preferences. Test plan: 1- Go to administration > system preferences 2- View any system preference with Display/Don't display pair of options (e.g. OPACAcquisitionDetails) 3- Apply the patch 4- Refresh the page and notice it is now a Show/Don't show pair instead 5- Loop the steps with other system preferences until satisfied
Created attachment 135175 [details] [review] Bug 27519: Normalize Show/Don't show in system preferences Replace Display/Don't display (and some other pairs) by Show/Don't show in system preferences. Test plan: 1- Go to administration > system preferences 2- View any system preference with Display/Don't display pair of options (e.g. OPACAcquisitionDetails) 3- Apply the patch 4- Refresh the page and notice it is now a Show/Don't show pair instead 5- Loop the steps with other system preferences until satisfied Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
I love consistency for terminology, so this is great! I have two suggestions to move the "Show/Don't show" options to the start of the system preference text, rather than at the end, to be as consistent as possible with how it is used elsewhere: - noItemTypeImages: . Updated text: Show itemtype icons in the staff interface: Show/Don't show . Change to: Show/Don't show itemtype icons in the staff interface. - OpacNoItemTypeImages: . Updated text: Show itemtype icons in the OPAC: Show/Don't show . Change to: Show/Don't show itemtype icons in the OPAC. I'll also add to the terminology list: https://wiki.koha-community.org/wiki/Terminology
Created attachment 135203 [details] [review] Bug 27519: Normalize Show/Don't show in system preferences Replace Display/Don't display (and some other pairs) by Show/Don't show in system preferences. Test plan: 1- Go to administration > system preferences 2- View any system preference with Display/Don't display pair of options (e.g. OPACAcquisitionDetails) 3- Apply the patch 4- Refresh the page and notice it is now a Show/Don't show pair instead 5- Loop the steps with other system preferences until satisfied Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
(In reply to David Nind from comment #5) > I love consistency for terminology, so this is great! > > I have two suggestions to move the "Show/Don't show" options to the start of > the system preference text, rather than at the end, to be as consistent as > possible with how it is used elsewhere: > > - noItemTypeImages: > . Updated text: Show itemtype icons in the staff interface: Show/Don't show > . Change to: Show/Don't show itemtype icons in the staff interface. > > - OpacNoItemTypeImages: > . Updated text: Show itemtype icons in the OPAC: Show/Don't show > . Change to: Show/Don't show itemtype icons in the OPAC. > > I'll also add to the terminology list: > https://wiki.koha-community.org/wiki/Terminology Added the suggested changes in noItemTypeImages and OpacNoItemTypeImages.
(In reply to Shi Yao Wang from comment #7) > (In reply to David Nind from comment #5) > > I love consistency for terminology, so this is great! > > > > I have two suggestions to move the "Show/Don't show" options to the start of > > the system preference text, rather than at the end, to be as consistent as > > possible with how it is used elsewhere: > > > > - noItemTypeImages: > > . Updated text: Show itemtype icons in the staff interface: Show/Don't show > > . Change to: Show/Don't show itemtype icons in the staff interface. > > > > - OpacNoItemTypeImages: > > . Updated text: Show itemtype icons in the OPAC: Show/Don't show > > . Change to: Show/Don't show itemtype icons in the OPAC. > > > > I'll also add to the terminology list: > > https://wiki.koha-community.org/wiki/Terminology > > Added the suggested changes in noItemTypeImages and OpacNoItemTypeImages. Hi Shi Yao. Thanks for updating. However, I think I may have confused things! I meant having the dropdown list with the choice at the front, rather than at the end of the sentence - eliminating the "double" show. For example: - For OpacNoItemTypeImages it should read as: [Show/Don't show] itemtype icons in the OPAC. - Rather than: Show/Don't show itemtype icons in the OPAC: [Show/Don't show] Hope that makes sense! David
Created attachment 135215 [details] [review] Bug 27519: Normalize Show/Don't show in system preferences Replace Display/Don't display (and some other pairs) by Show/Don't show in system preferences. Test plan: 1- Go to administration > system preferences 2- View any system preference with Display/Don't display pair of options (e.g. OPACAcquisitionDetails) 3- Apply the patch 4- Refresh the page and notice it is now a Show/Don't show pair instead 5- Loop the steps with other system preferences until satisfied Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 135217 [details] [review] Bug 27519: Normalize Show/Don't show in system preferences Replace Display/Don't display (and some other pairs) by Show/Don't show in system preferences. Test plan: 1- Go to administration > system preferences 2- View any system preference with Display/Don't display pair of options (e.g. OPACAcquisitionDetails) 3- Apply the patch 4- Refresh the page and notice it is now a Show/Don't show pair instead 5- Loop the steps with other system preferences until satisfied Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: David Nind <david@davidnind.com>
Thanks Shi Yao for updating! I've added my sign off as well, to show the QA I've checked the change0
No problem David. Thanks for the sign offs!
Created attachment 135478 [details] [review] Bug 27519: Normalize Show/Don't show in system preferences Replace Display/Don't display (and some other pairs) by Show/Don't show in system preferences. Test plan: 1- Go to administration > system preferences 2- View any system preference with Display/Don't display pair of options (e.g. OPACAcquisitionDetails) 3- Apply the patch 4- Refresh the page and notice it is now a Show/Don't show pair instead 5- Loop the steps with other system preferences until satisfied Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to master for 22.11. Nice work everyone, thanks!
Backported to 22.05.x for 22.05.03
Great work on the docs too Caroline.. merging now.