Using NOW() to set a date field should be avoided as the SQL server timezone may not match reflect the koha instance timezone.
Created attachment 116011 [details] [review] Bug 27574: Update \NOW() to dt_from_string for Accounts This patch replaces all instances of setting the date/timestamp fields for accounts related tables from the SQL literal \'NOW()' to Koha::DateUtils dt_from_string so we get properly localised dates.
Working on unit tests for this
Hmm... after discussing this with Jonathan we agree this is perhaps a solved problem already with bug 20123
Created attachment 116029 [details] [review] Bug 27574: Update \NOW() to dt_from_string for Accounts This patch replaces all instances of setting the date/timestamp fields for accounts related tables from the SQL literal \'NOW()' to Koha::DateUtils dt_from_string so we get properly localised dates. We also update the unit tests
Are we sure? Aren't we setting the timezone on connection time? In that case, wouldn't NOW() be already using the timezone? I'm worried we are double escaping here (hehe).