The new(ish) cash management options in Koha aren't clearly defined... you can enable parts of the system without enabling all of it. We should try to clarify the module by more clearly defining how it fits together. I propose to add a 'Cash management' heading under 'Tools' to move the 'Cashuup registers' option to and renaming some of the interface area's to better clarify their purposes.
Created attachment 116156 [details] [review] Bug 27583: Proposed terminology changes This patch impliments some terminology changes and clarifications for the cash management system Test plan 1/ Apply the patches 2/ Enable 'UseCashRegisters' 3/ Navigate around the cash management system (via the Tools menu) 4/ Enable 'EnablePointOfSale' 5/ Navigate around the cash management system (via the Point of sale module) 6/ Comment on what you think about the changes
Created attachment 116157 [details] [review] Bug 27583: Proposed terminology changes This patch impliments some terminology changes and clarifications for the cash management system Test plan 1/ Apply the patches 2/ Enable 'UseCashRegisters' 3/ Navigate around the cash management system (via the Tools menu) 4/ Enable 'EnablePointOfSale' 5/ Navigate around the cash management system (via the Point of sale module) 6/ Comment on what you think about the changes
Created attachment 118127 [details] [review] Bug 27583: Proposed terminology changes This patch impliments some terminology changes and clarifications for the cash management system Test plan 1/ Apply the patches 2/ Enable 'UseCashRegisters' 3/ Navigate around the cash management system (via the Tools menu) 4/ Enable 'EnablePointOfSale' 5/ Navigate around the cash management system (via the Point of sale module) 6/ Comment on what you think about the changes Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>
I like these changes - the placement is logical, and I like the way it displays when you're logged in with a till attached to your session vs without. The POS menu, in particular, is much improved.
Comment on attachment 118127 [details] [review] Bug 27583: Proposed terminology changes Review of attachment 118127 [details] [review]: ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/modules/pos/register.tt @@ +19,5 @@ > +<div id="breadcrumbs"> > + <a href="/cgi-bin/koha/mainpage.pl">Home</a> > + › <a href="/cgi-bin/koha/tools/tools-home.pl">Cash management</a> > + › Transaction history for [% register.name | html %] > +</div> Please don't do this - it breaks the strings up for translations. It's easier to translate the full path for context.
(In reply to Katrin Fischer from comment #5) > Comment on attachment 118127 [details] [review] [review] > Bug 27583: Proposed terminology changes > > Review of attachment 118127 [details] [review] [review]: > ----------------------------------------------------------------- > > ::: koha-tmpl/intranet-tmpl/prog/en/modules/pos/register.tt > @@ +19,5 @@ > > +<div id="breadcrumbs"> > > + <a href="/cgi-bin/koha/mainpage.pl">Home</a> > > + › <a href="/cgi-bin/koha/tools/tools-home.pl">Cash management</a> > > + › Transaction history for [% register.name | html %] > > +</div> > > Please don't do this - it breaks the strings up for translations. It's > easier to translate the full path for context. Actually I am having trouble to prove that claim and have quite some errors running gulp po:update hmm.
I've proved it for you here.. sorry, I wasn't aware that splitting it nicely over lines caused translations issues.. it's done like that all over the codebase and in my opinion, is much more readable.. such a shame we can't use it :(.
Having said that, from my layman's perspective having the segments as distinct strings (and being able to share a single translation for the first chunk 'Home' for example seems better for translation rather than worse to me..
Created attachment 118224 [details] [review] Bug 27583: (QA follow-up) Undo developer readability I added new lines for each slug of the breadcrumbs (As is the case in many other locations in Koha), but Katrin highlighted that this breaks the string into distinct slugs without context for translation and this is apparently a bad thing. So this patch undoes that change and puts them back onto one long line.
OK.. I've added a followup to undo the readability improvements. Katrin, can you bring this up as a topic for a dev meeting.. if we really do need to keep breadcrumb slugs all on one line I feel we should have a guideline written for it with clear reasoning so QA team are aware and can enforce the policy.
Obsoleted my final patch.. after some discussion we decided the split wasn't a bad thing.
Created attachment 120912 [details] [review] Bug 27583: Proposed terminology changes This patch impliments some terminology changes and clarifications for the cash management system Test plan 1/ Apply the patches 2/ Enable 'UseCashRegisters' 3/ Navigate around the cash management system (via the Tools menu) 4/ Enable 'EnablePointOfSale' 5/ Navigate around the cash management system (via the Point of sale module) 6/ Comment on what you think about the changes Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>
Created attachment 122690 [details] [review] Bug 27583: Proposed terminology changes This patch impliments some terminology changes and clarifications for the cash management system Test plan 1/ Apply the patches 2/ Enable 'UseCashRegisters' 3/ Navigate around the cash management system (via the Tools menu) 4/ Enable 'EnablePointOfSale' 5/ Navigate around the cash management system (via the Point of sale module) 6/ Comment on what you think about the changes Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Pushed to master for 21.11, thanks to everybody involved!
Enhancement not backported.