These policies can be set to blank, this affects the holds queue and presumably other areas. There needs to be a visual indication of the rule not being set vs the rule being set to blank - or the rule should not save when dropdown is set to 'Not set' To recreate: 1 - Go to Admin->Circulation rules and pick a branch with no rules set 2 - Under "Default checkout, hold and return policy" leave all fields blank and hit save 3 - Check the DB, five rules have been set: SELECT * FROM circulation_rules WHERE branchcode="BRANCH"; 4 - In the staff client, click 'Unset' 5 - There is a warning, but no visible change 6 - Check the DB, the rules are gone
IMO it should not modify the behaviour, that's where the issue is. For instance with patron_maxissueqty we are comparing with '' 539 if (defined($branch_borrower_circ_rule->{patron_maxissueqty}) and $branch_borrower_circ_rule->{patron_maxissueqty} ne '') {