Some reports have a long and detailed notes section pertaining to a given report. With the html filter it can be very difficult to parse out those notes. Is there any reason we cannot use a $raw filter in this situation?
Created attachment 116783 [details] [review] Bug 27691: Add $raw filter to report notes output To test: Add a report with some notes that include HTML: <p>TEST</p> Run the report, the HTML displays literally Apply patch Run the report again. HTML looks good
Created attachment 116836 [details] [review] Bug 27691: Add $raw filter to report notes output To test: Add a report with some notes that include HTML: <p>TEST</p> Run the report, the HTML displays literally Apply patch Run the report again. HTML looks good Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov>
The html looked great. This is a big improvement.
Created attachment 116853 [details] [review] Bug 27691: Add $raw filter to report notes output To test: Add a report with some notes that include HTML: <p>TEST</p> Run the report, the HTML displays literally Apply patch Run the report again. HTML looks good Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
The problem is that this saved_sql.notes field can be filled in by Mana, so I don't think we can trust the data coming from there. We should first make sure the data is sanitized before it is inserted into the Mana DB.
Is there a way we could remove HTML elements before uploading to Mana as a compromise? I believe the tagging feature does "scrubbing" of the input in a way, maybe that could be useful?
Yes, it's what I meant with "sanitized", HTML tags must be removed.