The "search for tag" field in MARC framework administration has the same ID as "search system preferences" field in the header search box. This is invalid and can cause problems when references elements by ID in JavaScript or CSS.
Created attachment 116925 [details] [review] Bug 27713: Duplicate search field IDs in MARC framework administration template This patch makes a minor change to the MARC framework administration template so that the ID of a form field on the page isn't a duplicate of one in the header search form. To test, apply the patch and go to Administration -> MARC bibliographic framework -> MARC structure. - Test the "Search for tag" form field to confirm that it works correctly. - Validate the HTML of the page to confirm that there are no "Duplicate ID" errors.
Created attachment 117121 [details] [review] Bug 27713: Duplicate search field IDs in MARC framework administration template This patch makes a minor change to the MARC framework administration template so that the ID of a form field on the page isn't a duplicate of one in the header search form. To test, apply the patch and go to Administration -> MARC bibliographic framework -> MARC structure. - Test the "Search for tag" form field to confirm that it works correctly. - Validate the HTML of the page to confirm that there are no "Duplicate ID" errors. Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Created attachment 117161 [details] [review] Bug 27713: Duplicate search field IDs in MARC framework administration template This patch makes a minor change to the MARC framework administration template so that the ID of a form field on the page isn't a duplicate of one in the header search form. To test, apply the patch and go to Administration -> MARC bibliographic framework -> MARC structure. - Test the "Search for tag" form field to confirm that it works correctly. - Validate the HTML of the page to confirm that there are no "Duplicate ID" errors. Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Always good to improve these things.. Passing QA
Pushed to master for 21.05, thanks to everybody involved!
Pushed to 20.11.x for 20.11.04
Pushed to 20.05.x for 20.05.10
Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed.