When you start the process of placing a hold in the staff interface for a title which already has holds, the table showing information about those holds has controls for changing the existing holds' pickup location. That dropdown queries the API to get available pickup locations, but the list of libraries is returned in order by branchcode. It should be ordered by library name instead.
Created attachment 117087 [details] [review] Bug 27733: Add "_sort_by" paramter to pickup_locations API query On the place hold page in the staff interface, add a "_sort_by" parameter with the "name" value so that the list of libraries is returned in name order. To test, apply the patch and locate a title in the staff interface which has holds on it. - View the holds information for that title. - In the table of exising holds, expand the "Pickup library" dropdown for any of the entries. The list of libraries should be in order by library name.
Created attachment 117093 [details] [review] Bug 27733: Add "_sort_by" paramter to pickup_locations API query On the place hold page in the staff interface, add a "_sort_by" parameter with the "name" value so that the list of libraries is returned in name order. To test, apply the patch and locate a title in the staff interface which has holds on it. - View the holds information for that title. - In the table of exising holds, expand the "Pickup library" dropdown for any of the entries. The list of libraries should be in order by library name. Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov>
Much better, Passing QA
Created attachment 117159 [details] [review] Bug 27733: Add "_sort_by" paramter to pickup_locations API query On the place hold page in the staff interface, add a "_sort_by" parameter with the "name" value so that the list of libraries is returned in name order. To test, apply the patch and locate a title in the staff interface which has holds on it. - View the holds information for that title. - In the table of exising holds, expand the "Pickup library" dropdown for any of the entries. The list of libraries should be in order by library name. Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Pushed to master for 21.05, thanks to everybody involved!
Depends on Bug 27732 not in 20.11.x