cateditor-widgets-marc21.inc uses DefaultLanguageField008 for the initial value of the language in 008/35-37, but just hardcodes xxu rather than using the companion pref DefaultCountryField008 for 008/15-17. Since using the pref requires a fallback when it's unset, and bug 27738 proposes changing the current fallback in the basic editor, this bug should wait on an outcome there before being fixed.
Created attachment 119092 [details] [review] Bug 27739: Advanced editor should use DefaultCountryField008 preference Uses the system preference DefaultCountryField008, falling back to ||| (no attempt to code) if it is not set, for 008/15-17 place of publication in the advanced cataloging editor.. Test plan: 1) Apply patch and restart all the things, something's over-cached here 2) Administration - Toggle the preference EnableAdvancedCatalogingEditor to "Enable", verify the preference DefaultCountryField008 is empty 3) Cataloging - Advanced editor 4) In field 008, verify that the three characters after the two sets of four blank spaces are ||| 5) Administration - Set DefaultCountryField008 to fr 6) Cataloging - Advanced editor 7) In field 008, verify that the three characters after the two sets of four blank spaces are "fr " (including the space, so following characters haven't shifted left, and the last character is still d)
Created attachment 119146 [details] [review] Bug 27739: Advanced editor should use DefaultCountryField008 preference Uses the system preference DefaultCountryField008, falling back to ||| (no attempt to code) if it is not set, for 008/15-17 place of publication in the advanced cataloging editor.. Test plan: 1) Apply patch and restart all the things, something's over-cached here 2) Administration - Toggle the preference EnableAdvancedCatalogingEditor to "Enable", verify the preference DefaultCountryField008 is empty 3) Cataloging - Advanced editor 4) In field 008, verify that the three characters after the two sets of four blank spaces are ||| 5) Administration - Set DefaultCountryField008 to fr 6) Cataloging - Advanced editor 7) In field 008, verify that the three characters after the two sets of four blank spaces are "fr " (including the space, so following characters haven't shifted left, and the last character is still d) Signed-off-by: David Nind <david@davidnind.com>
Created attachment 119681 [details] [review] Bug 27739: Advanced editor should use DefaultCountryField008 preference Uses the system preference DefaultCountryField008, falling back to ||| (no attempt to code) if it is not set, for 008/15-17 place of publication in the advanced cataloging editor.. Test plan: 1) Apply patch and restart all the things, something's over-cached here 2) Administration - Toggle the preference EnableAdvancedCatalogingEditor to "Enable", verify the preference DefaultCountryField008 is empty 3) Cataloging - Advanced editor 4) In field 008, verify that the three characters after the two sets of four blank spaces are ||| 5) Administration - Set DefaultCountryField008 to fr 6) Cataloging - Advanced editor 7) In field 008, verify that the three characters after the two sets of four blank spaces are "fr " (including the space, so following characters haven't shifted left, and the last character is still d) Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
This makes behavior match the basic cataloging editor, nice work!
Pushed to master for 21.05, thanks to everybody involved!
Pushed to 20.11.x for 20.11.05
Pushed to 20.05.x for 20.05.11
Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed.