Actually hyphens are removed from ISBN when using acquisition or z3950 cataloguing or with bulkmarcimport. I propose to add this behavior in TransformMarcToKoha() so MARC data is unchanged, but biblioitems.isbn is without hyphens. This can be used if search using SQL and in reports.
Sort of a renew of Bug 6590
Created attachment 117277 [details] [review] Bug 27774: Always remove hyphens from ISBN when cataloging Actually hyphens are removed from ISBN when using acquisition or z3950 cataloguing or with bulkmarcimport. I propose to add this behavior in TransformMarcToKoha() so MARC data is unchanged, but biblioitems.isbn is without hyphens. This can be used if search using SQL and in reports. We may after this remove other codes that remove hyphens before cataloguing a biblio record. Test plan : 1) Create a new record with an ISBN with hyphen, ie 978-0008376109 2) Save 3) Export to MARCXML and see ISBN has hyphen 4) Look into database : select isbn from biblioitems where bilionumber=xxx 5) Check you see ISBN without hyphen
Created attachment 117329 [details] [review] Bug 27774: Always remove hyphens from ISBN when cataloging Actually hyphens are removed from ISBN when using acquisition or z3950 cataloguing or with bulkmarcimport. I propose to add this behavior in TransformMarcToKoha() so MARC data is unchanged, but biblioitems.isbn is without hyphens. This can be used if search using SQL and in reports. We may after this remove other codes that remove hyphens before cataloguing a biblio record. Test plan : 1) Create a new record with an ISBN with hyphen, ie 978-0008376109 2) Save 3) Export to MARCXML and see ISBN has hyphen 4) Look into database : select isbn from biblioitems where bilionumber=xxx 5) Check you see ISBN without hyphen Signed-off-by: Frank Hansen <frank.hansen@ub.lu.se>
Created attachment 119413 [details] [review] Bug 27774: Always remove hyphens from ISBN when cataloging Actually hyphens are removed from ISBN when using acquisition or z3950 cataloguing or with bulkmarcimport. I propose to add this behavior in TransformMarcToKoha() so MARC data is unchanged, but biblioitems.isbn is without hyphens. This can be used if search using SQL and in reports. We may after this remove other codes that remove hyphens before cataloguing a biblio record. Test plan : 1) Create a new record with an ISBN with hyphen, ie 978-0008376109 2) Save 3) Export to MARCXML and see ISBN has hyphen 4) Look into database : select isbn from biblioitems where bilionumber=xxx 5) Check you see ISBN without hyphen Signed-off-by: Frank Hansen <frank.hansen@ub.lu.se> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 119414 [details] [review] Bug 27774: Add unit test Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 119452 [details] [review] Bug 27774: Add unit test Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> JD amended patch: s/all three mappings/all mappings/
From bug 6590 it seems that people didn't agree on removing hyphens for ISBNs Bug 6590 comment 15: > In UNIMARC, ISBN field is supposed to contain ISBN as written on the > book cover. ISBN without hyphens can be stored in EAN (073) field. Why did you open a separate bug report?
Piouf I don't remember. I'm OK if this one is closed as duplicate.
*** This bug has been marked as a duplicate of bug 6590 ***