I found this bug while testing Bug 5697: Using the system for defining a column name placeholder (Bug 23390), if there is a space inside the column name placeholder it won't work. The SQL example in Bug 5697: SELECT i.itemnumber, i.itemnumber as Exemplarnummber, [[i.itemnumber| itemnumber for batch]], CONCAT('<a href=\"/cgi-bin/koha/cataloguing/additem.pl?op=edititem&biblionumber=', i.biblionumber, '&itemnumber=', i.itemnumber, '#edititem', '\">', i.itemnumber, '</a>' ) AS "itemnumber as edit link" FROM items i "[[i.itemnumber| itemnumber for batch]]" has a space before "itemnumber for batch." With that space removed it works as expected.
What does not work exactly? I copy/pasted the query to create a new SQL report, I run it and see the table result with the 4 headers: itemnumber, Exemplarnummber, itemnumber for batch, itemnumber as edit link
(In reply to Jonathan Druart from comment #1) > What does not work exactly? > I copy/pasted the query to create a new SQL report, I run it and see the > table result with the 4 headers: itemnumber, Exemplarnummber, itemnumber for > batch, itemnumber as edit link The third column should look like the first - linked to actions. But it doesn't work.
Created attachment 153059 [details] [review] Bug 27824: Add a test
Created attachment 153060 [details] [review] Bug 27824: Trim column headers To support additional spaces. Using the system for defining a column name placeholder (Bug 23390), if there is a space inside the column name placeholder it won't work. The SQL example in Bug 5697: SELECT i.itemnumber, i.itemnumber as Exemplarnummber, [[i.itemnumber| itemnumber for batch]], CONCAT('<a href=\"/cgi-bin/koha/cataloguing/additem.pl?op=edititem&biblionumber=', i.biblionumber, '&itemnumber=', i.itemnumber, '#edititem', '\">', i.itemnumber, '</a>' ) AS "itemnumber as edit link" FROM items i "[[i.itemnumber| itemnumber for batch]]" has a space before "itemnumber for batch." With that space removed it works as expected.
Created attachment 153064 [details] [review] Bug 27824: Add a test Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 153065 [details] [review] Bug 27824: Trim column headers To support additional spaces. Using the system for defining a column name placeholder (Bug 23390), if there is a space inside the column name placeholder it won't work. The SQL example in Bug 5697: SELECT i.itemnumber, i.itemnumber as Exemplarnummber, [[i.itemnumber| itemnumber for batch]], CONCAT('<a href=\"/cgi-bin/koha/cataloguing/additem.pl?op=edititem&biblionumber=', i.biblionumber, '&itemnumber=', i.itemnumber, '#edititem', '\">', i.itemnumber, '</a>' ) AS "itemnumber as edit link" FROM items i "[[i.itemnumber| itemnumber for batch]]" has a space before "itemnumber for batch." With that space removed it works as expected. Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 153220 [details] [review] Bug 27824: Add a test Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 153221 [details] [review] Bug 27824: Trim column headers To support additional spaces. Using the system for defining a column name placeholder (Bug 23390), if there is a space inside the column name placeholder it won't work. The SQL example in Bug 5697: SELECT i.itemnumber, i.itemnumber as Exemplarnummber, [[i.itemnumber| itemnumber for batch]], CONCAT('<a href=\"/cgi-bin/koha/cataloguing/additem.pl?op=edititem&biblionumber=', i.biblionumber, '&itemnumber=', i.itemnumber, '#edititem', '\">', i.itemnumber, '</a>' ) AS "itemnumber as edit link" FROM items i "[[i.itemnumber| itemnumber for batch]]" has a space before "itemnumber for batch." With that space removed it works as expected. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 23.11. Nice work everyone, thanks!
Thanks for all the hard work! Pushed to 23.05.x for the next release
Nice work everyone! Pushed to oldstable for 22.11.x