Bug 27917 - Make it clear that standing orders cannot create items at point of ordering
Summary: Make it clear that standing orders cannot create items at point of ordering
Status: CONFIRMED
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-03-10 16:06 UTC by Andrew Fuerste-Henry
Modified: 2025-02-11 19:59 UTC (History)
5 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 27917: Prevent inconsistent create_items value (1.71 KB, patch)
2021-03-11 14:37 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Fuerste-Henry 2021-03-10 16:06:23 UTC
When creating a basket, one chooses whether one wants to create item records when ordering, when receiving, or when cataloging.

If your basket is a standing order basket, then it cannot create items when ordering. Koha will allow you to pick "placing an order" for when to create items for a standing order basket, but then will not create the item.

When creating a basket, we should not allow one to choose "placing an order" for "Create items when" if one has checked the Standing Order box. We should also not allow one to select default for "Create items when" when making a standing order basket if the AcqCreateItem syspref is set to "placing an order."
Comment 1 Jonathan Druart 2021-03-11 14:37:34 UTC
Created attachment 118131 [details] [review]
Bug 27917: Prevent inconsistent create_items value
Comment 2 Jonathan Druart 2021-03-11 14:39:23 UTC
Here is a patch for the UI, but I don't think it's enough. We should enforce that at the module level (Koha::Acquisition::Basket->store).

However how to behave when we edit a basket?

Especially if you edit a basket with inconsistent values (the create_items cannot be modified once the basket has been created). Does it make sense to let the "is standing" checkbox editable?
Comment 3 Andrew Fuerste-Henry 2021-03-11 15:38:42 UTC
> However how to behave when we edit a basket?
> 
> Especially if you edit a basket with inconsistent values (the create_items
> cannot be modified once the basket has been created). Does it make sense to
> let the "is standing" checkbox editable?

That feels like it may be a followup bug. I agree it's weirdly inconsistent that we can change the is_standing value after a basket has been created but not the create_items value. I'm not sure, however, on the best path forward. My first thought is just to make is_standing no longer editable after basket creation, but that may cause issues for folks.
Comment 4 Jonathan Druart 2021-03-12 08:46:30 UTC
Katrin, what's your opinion on this?
Comment 5 Katrin Fischer 2021-04-02 14:58:58 UTC
Hope I understood it all correctly:

- The standing order checkbox needs to remain editable in the basket. At the moment I know of no other way to "close" out a standing order than to make it no longer a standing order first. 

- It makes sense to only offer cataloguing and on receive as options when standing order is checked.

Should we include a database update maybe to set all the standing orders with "on order" to "cataloguing"?
Comment 6 Esther Melander 2025-02-11 19:15:19 UTC
I ran into this today and perhaps this should move from discussion to a bug:

To replicate

1. Find a vendor and add a basket.
2. Select standing order and create items on order.
3. Add an order to the basket. Look at the record in the catalog and see no items are created. Look at the Acquisitions details tab of the record and see an item exists there.
4. Return to the vendor and receive.
5. Enter the invoice and receive the standing order.
6. Enter quantity to receive as '1'

Notice there are no options presented for the item creation.

7. Click on confirm.
8. Return to the basket and see the "received" item.
9. Return to the bibliographic record and see there no items on the holdings table.
10. Click on the Acquisitions tab and see there are now two "items", the stub item for the bibliographic record creation and the actual received item.

No item was created because Koha was told to create the item when the order is placed, which seems to be in conflict with the concept of standing orders.

Repeat the above but change the basket to create the item on receiving. The item will be created and will show on the holdings table. The acquisition details tab will have two items, the stub item and the actual item.

If standing order is checked in the basket then the only options should be to create the item on receiving or cataloging.